-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes ByteArrayIndexInput::validatePos and adds UT #10551
Fixes ByteArrayIndexInput::validatePos and adds UT #10551
Conversation
Gradle Check (Jenkins) Run Completed with:
|
Compatibility status:Checks if related components are compatible with change 407ddff Incompatible componentsSkipped componentsCompatible componentsCompatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/sql.git] |
Gradle Check (Jenkins) Run Completed with:
|
2ac1b89
to
78ade58
Compare
❌ Gradle check result for 78ade58: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
@parasjain1 Can you fix the spotless error here? |
This PR is stalled because it has been open for 30 days with no activity. |
Hi @parasjain1, do we have any updates? You can run |
This PR is stalled because it has been open for 30 days with no activity. |
Signed-off-by: Paras Jain <[email protected]>
Signed-off-by: Andrew Ross <[email protected]>
78ade58
to
407ddff
Compare
❕ Gradle check result for 407ddff: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10551 +/- ##
============================================
- Coverage 71.49% 71.45% -0.05%
+ Complexity 59859 59846 -13
============================================
Files 4959 4959
Lines 281129 281129
Branches 40857 40857
============================================
- Hits 201003 200882 -121
- Misses 63425 63609 +184
+ Partials 16701 16638 -63 ☔ View full report in Codecov by Sentry. |
* Prevent read beyond slice boundary in ByteArrayIndexInput Signed-off-by: Paras Jain <[email protected]> * Fix spotless errors Signed-off-by: Andrew Ross <[email protected]> --------- Signed-off-by: Paras Jain <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Paras Jain <[email protected]> Co-authored-by: Andrew Ross <[email protected]> (cherry picked from commit bb0b4b0) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…t#10551) * Prevent read beyond slice boundary in ByteArrayIndexInput Signed-off-by: Paras Jain <[email protected]> * Fix spotless errors Signed-off-by: Andrew Ross <[email protected]> --------- Signed-off-by: Paras Jain <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Paras Jain <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
…t#10551) * Prevent read beyond slice boundary in ByteArrayIndexInput Signed-off-by: Paras Jain <[email protected]> * Fix spotless errors Signed-off-by: Andrew Ross <[email protected]> --------- Signed-off-by: Paras Jain <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Paras Jain <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
…t#10551) * Prevent read beyond slice boundary in ByteArrayIndexInput Signed-off-by: Paras Jain <[email protected]> * Fix spotless errors Signed-off-by: Andrew Ross <[email protected]> --------- Signed-off-by: Paras Jain <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Paras Jain <[email protected]> Co-authored-by: Andrew Ross <[email protected]> Signed-off-by: Shivansh Arora <[email protected]>
…t#10551) * Prevent read beyond slice boundary in ByteArrayIndexInput Signed-off-by: Paras Jain <[email protected]> * Fix spotless errors Signed-off-by: Andrew Ross <[email protected]> --------- Signed-off-by: Paras Jain <[email protected]> Signed-off-by: Andrew Ross <[email protected]> Co-authored-by: Paras Jain <[email protected]> Co-authored-by: Andrew Ross <[email protected]>
Description
Fixes
ByteArrayIndexInput::validatePos
and adds UTRelated Issues
Resolves #10481
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.