Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix to include static settings in addition to dynamic repo metadata #10452

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

vikasvb90
Copy link
Contributor

@vikasvb90 vikasvb90 commented Oct 6, 2023

Description

Fix to include static settings in addition to dynamic repo metadata

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…ettings during s3 plugin reload

Signed-off-by: vikasvb90 <[email protected]>
@vikasvb90 vikasvb90 force-pushed the s3_plugin_reload_fix branch from fb5c8ec to a87735f Compare October 6, 2023 10:25
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Compatibility status:

Checks if related components are compatible with change fb5c8ec

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testStatsResponseFromLocalNode

@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Merging #10452 (a87735f) into main (1eec0f1) will increase coverage by 0.71%.
Report is 10 commits behind head on main.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main   #10452      +/-   ##
============================================
+ Coverage     70.41%   71.13%   +0.71%     
- Complexity    57696    58373     +677     
============================================
  Files          4843     4843              
  Lines        275205   275204       -1     
  Branches      40068    40068              
============================================
+ Hits         193793   195771    +1978     
+ Misses        65047    63112    -1935     
+ Partials      16365    16321      -44     
Files Coverage Δ
...a/org/opensearch/repositories/s3/S3Repository.java 69.29% <0.00%> (+0.60%) ⬆️

... and 565 files with indirect coverage changes

@gbbafna gbbafna merged commit 4fee40d into opensearch-project:main Oct 6, 2023
17 of 19 checks passed
@gbbafna gbbafna added backport 2.x Backport to 2.x branch backport 2.11 labels Oct 6, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2023
…ettings during s3 plugin reload (#10452)

Signed-off-by: vikasvb90 <[email protected]>
(cherry picked from commit 4fee40d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 6, 2023
…ettings during s3 plugin reload (#10452)

Signed-off-by: vikasvb90 <[email protected]>
(cherry picked from commit 4fee40d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Oct 6, 2023
…ettings during s3 plugin reload (#10452) (#10455)

(cherry picked from commit 4fee40d)

Signed-off-by: vikasvb90 <[email protected]>
kaushalmahi12 pushed a commit to kaushalmahi12/OpenSearch that referenced this pull request Oct 6, 2023
gbbafna pushed a commit that referenced this pull request Oct 9, 2023
…ettings during s3 plugin reload (#10452) (#10456)

(cherry picked from commit 4fee40d)

Signed-off-by: vikasvb90 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 9, 2023
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…ettings during s3 plugin reload (opensearch-project#10452)

Signed-off-by: vikasvb90 <[email protected]>
Signed-off-by: Shivansh Arora <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants