Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[S3 Repository] Make bulk delete size configurable #10445

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

gbbafna
Copy link
Collaborator

@gbbafna gbbafna commented Oct 6, 2023

Description

Make bulk delete size configurable

Related Issues

Resolves #10451

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Compatibility status:

Checks if related components are compatible with change c675189

Incompatible components

Incompatible components: [https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/neural-search.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions github-actions bot added the enhancement Enhancement or improvement to existing feature or request label Oct 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Member

@ashking94 ashking94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Oct 6, 2023
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@gbbafna
Copy link
Collaborator Author

gbbafna commented Oct 11, 2023


* What went wrong:
Execution failed for task ':modules:lang-expression:internalClusterTest'.

Gradle check failure is not related . Will retry .

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@gbbafna
Copy link
Collaborator Author

gbbafna commented Oct 11, 2023

> Task :server:internalClusterTest

Tests with failures:
 - org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testIndexCreateBlockIsRemovedWhenAnyNodesNotExceedHighWatermarkWithAutoReleaseEnabled
 - org.opensearch.search.scroll.SearchScrollWithFailingNodesIT.testScanScrollWithShardExceptions {p0={"search.concurrent_segment_search.enabled":"false"}}
 - org.opensearch.search.scroll.SearchScrollWithFailingNodesIT.testScanScrollWithShardExceptions {p0={"search.concurrent_segment_search.enabled":"true"}}
 

testIndexCreateBlockIsRemovedWhenAnyNode hasn't been flaky as of yet. Retrying gradle again .

@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Merging #10445 (c675189) into main (2bf63c9) will increase coverage by 0.04%.
Report is 17 commits behind head on main.
The diff coverage is 66.66%.

@@             Coverage Diff              @@
##               main   #10445      +/-   ##
============================================
+ Coverage     71.17%   71.22%   +0.04%     
- Complexity    58371    58379       +8     
============================================
  Files          4843     4843              
  Lines        275264   275269       +5     
  Branches      40076    40076              
============================================
+ Hits         195928   196054     +126     
+ Misses        62882    62787      -95     
+ Partials      16454    16428      -26     
Files Coverage Δ
...rg/opensearch/repositories/s3/S3BlobContainer.java 79.20% <100.00%> (-0.86%) ⬇️
...a/org/opensearch/repositories/s3/S3Repository.java 69.82% <100.00%> (+0.52%) ⬆️
...va/org/opensearch/repositories/s3/S3BlobStore.java 74.13% <33.33%> (-2.23%) ⬇️

... and 457 files with indirect coverage changes

@gbbafna gbbafna merged commit 9bcd7ea into opensearch-project:main Oct 11, 2023
15 of 16 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 11, 2023
Signed-off-by: Gaurav Bafna <[email protected]>
(cherry picked from commit 9bcd7ea)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Oct 12, 2023
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 19, 2023
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[S3 Repository Plugin] Configurable bulk delete size
3 participants