Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid size=0 for terminate_after tests #10436

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented Oct 6, 2023

Description

Avoid size=0 test flakiness for terminate_after tests: #9946
Need to do a deeper dive of the underlying issue, tracking that in #10435
Ran this test locally 1500 times and saw no failures.

Related Issues

Resolves #9946

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added flaky-test Random test failure that succeeds on second run Search Search query, autocomplete ...etc labels Oct 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Compatibility status:

Checks if related components are compatible with change 3d693ea

Incompatible components

Incompatible components: [https://github.com/opensearch-project/security-analytics.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/reporting.git]

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@jed326
Copy link
Collaborator Author

jed326 commented Oct 6, 2023

@reta @sohami @andrross could you help review? Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@jed326
Copy link
Collaborator Author

jed326 commented Oct 6, 2023

URL: https://build.ci.opensearch.org/job/gradle-check/27335/

Don't think I've seen this one before, created a new issue: #10469

@reta
Copy link
Collaborator

reta commented Oct 6, 2023

@reta @sohami @andrross could you help review? Thanks!

My apologies @jed326 , I am traveling now, will be able to take a look mid-next week

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Gradle Check (Jenkins) Run Completed with:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2023

Gradle Check (Jenkins) Run Completed with:

  • RESULT: UNSTABLE ❕
  • TEST FAILURES:
      1 org.opensearch.remotestore.SegmentReplicationUsingRemoteStoreIT.testDeleteOperations

@codecov
Copy link

codecov bot commented Oct 9, 2023

Codecov Report

Merging #10436 (3d693ea) into main (22ddcf1) will decrease coverage by 0.09%.
Report is 1 commits behind head on main.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##               main   #10436      +/-   ##
============================================
- Coverage     71.28%   71.20%   -0.09%     
+ Complexity    58480    58366     -114     
============================================
  Files          4843     4843              
  Lines        275265   275267       +2     
  Branches      40076    40076              
============================================
- Hits         196227   196007     -220     
- Misses        62621    62798     +177     
- Partials      16417    16462      +45     
Files Coverage Δ
...c/main/java/org/opensearch/index/IndexService.java 75.65% <ø> (-0.44%) ⬇️
...in/java/org/opensearch/index/shard/IndexShard.java 69.21% <0.00%> (-0.59%) ⬇️

... and 492 files with indirect coverage changes

@sohami sohami added the backport 2.x Backport to 2.x branch label Oct 10, 2023
@sohami sohami merged commit 74ffdb6 into opensearch-project:main Oct 10, 2023
18 of 19 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Oct 10, 2023
Signed-off-by: Jay Deng <[email protected]>
(cherry picked from commit 74ffdb6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sohami pushed a commit that referenced this pull request Oct 10, 2023
(cherry picked from commit 74ffdb6)

Signed-off-by: Jay Deng <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
deshsidd pushed a commit to deshsidd/OpenSearch that referenced this pull request Oct 19, 2023
austintlee pushed a commit to austintlee/OpenSearch that referenced this pull request Oct 23, 2023
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@jed326 jed326 deleted the 9946 branch August 7, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch flaky-test Random test failure that succeeds on second run Search Search query, autocomplete ...etc skip-changelog
Projects
None yet
3 participants