Skip to content

Commit

Permalink
Revert "Make High-Level-Rest-Client tests allow deprecation warning t…
Browse files Browse the repository at this point in the history
…emporarily, during deprecation of request parameter 'master_timeout' (#2702)" (#2744)

This reverts commit 6a2a33d.

During the process of deprecating REST API request parameter master_timeout and adding alternative parameter cluster_manager_timeout, I made High-Level-Rest-Client tests allow deprecation warning temporarily, by changing the argument of `setStrictDeprecationMode()` to false when building `RestClient` for tests, in the above commit / PR #2702,

This PR sets the High-Level-Rest-Client tests back to treating warning header as a failure.

Signed-off-by: Tianli Feng <[email protected]>
  • Loading branch information
Tianli Feng authored Apr 19, 2022
1 parent 18f4495 commit b45bfc9
Showing 1 changed file with 1 addition and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -824,8 +824,7 @@ protected String getProtocol() {
protected RestClient buildClient(Settings settings, HttpHost[] hosts) throws IOException {
RestClientBuilder builder = RestClient.builder(hosts);
configureClient(builder, settings);
// TODO: set the method argument to 'true' after PR https://github.com/opensearch-project/OpenSearch/pull/2683 merged.
builder.setStrictDeprecationMode(false);
builder.setStrictDeprecationMode(true);
return builder.build();
}

Expand Down

0 comments on commit b45bfc9

Please sign in to comment.