Handle NoSuchFileException when attempting to delete decref'd files.

To avoid divergent logic with remote store, we always incref/decref the segmentinfos.files(true) which includes the segments_n file. Decref to 0 will attempt to delete the file from the store and its possible this _n file does not yet exist. This change will ignore if we get a noSuchFile while attempting to delete. Signed-off-by: Marc Handalian <[email protected]>
opensearch-project · Jul 27, 2023 · 8476d5d · 8476d5d
1 parent fe6a88e
commit 8476d5d
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/server/src/main/java/org/opensearch/index/store/Store.java b/server/src/main/java/org/opensearch/index/store/Store.java
@@ -824,6 +824,10 @@ private void cleanupFiles(Collection<String> filesToConsiderForCleanup, String r
             try {
                 directory.deleteFile(reason, existingFile);
             } catch (IOException ex) {
+                if (ex instanceof NoSuchFileException) {
+                    // file doesn't exist, nothing to do.
+                    return;
+                }
                 if (existingFile.startsWith(IndexFileNames.SEGMENTS) || existingFile.startsWith(CORRUPTED_MARKER_NAME_PREFIX)) {
                     // TODO do we need to also fail this if we can't delete the pending commit file?
                     // if one of those files can't be deleted we better fail the cleanup otherwise we might leave an old commit