Skip to content

Commit

Permalink
comments
Browse files Browse the repository at this point in the history
Signed-off-by: Yupeng Fu <[email protected]>
  • Loading branch information
yupeng9 committed Jan 21, 2025
1 parent 8e7af9c commit 01126c5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ public void testKafkaIngestion() {
.put("ingestion_source.type", "kafka")
.put("ingestion_source.pointer.init.reset", "earliest")
.put("ingestion_source.param.topic", "test")
.put("ingestion_source.param.bootstrapServers", kafka.getBootstrapServers())
.put("ingestion_source.param.bootstrap_servers", kafka.getBootstrapServers())
.build(),
"{\"properties\":{\"name\":{\"type\": \"text\"},\"age\":{\"type\": \"integer\"}}}}"
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public class KafkaSourceConfig {
public KafkaSourceConfig(Map<String, Object> params) {
// TODO: better parsing and validation
this.topic = (String) Objects.requireNonNull(params.get("topic"));
this.bootstrapServers = (String) Objects.requireNonNull(params.get("bootstrapServers"));
this.bootstrapServers = (String) Objects.requireNonNull(params.get("bootstrap_servers"));
assert this.bootstrapServers != null;
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ public void testInitialize() {
KafkaConsumerFactory factory = new KafkaConsumerFactory();
Map<String, Object> params = new HashMap<>();
params.put("topic", "test-topic");
params.put("bootstrapServers", "localhost:9092");
params.put("bootstrap_servers", "localhost:9092");

factory.initialize(params);

Expand Down

0 comments on commit 01126c5

Please sign in to comment.