[Discover] fix PPL to not throw error if aggregation query fails

[joshuali925]

Description

The previous PR #8743 added handleFacetError if date_histogram aggregation failed, because otherwise the code will process the response as data, and calling rawAggs.data.datarows caused NPE.

The problem is that some PPL queries will not have a date_histogram, for example source = table | stats count(), and failure is expected. So it should not throw error there. This PR changes handleFacetError to continue, and renames handleFacetError to throwFacetError.

Issues Resolved

• skip

Screenshot

Testing the changes

added unit tests and locally tested

Changelog

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[github-actions]

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.89%. Comparing base (b31206a) to head (d181c28).
Report is 3 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8992   +/-   ##
=======================================
  Coverage   60.88%   60.89%           
=======================================
  Files        3802     3803    +1     
  Lines       91083    91106   +23     
  Branches    14383    14388    +5     
=======================================
+ Hits        55455    55476   +21     
  Misses      32086    32086           
- Partials     3542     3544    +2     

Flag	Coverage Δ
Linux_1	29.02% <ø> (ø)
Linux_2	56.38% <ø> (ø)
Linux_3	37.90% <ø> (ø)
Linux_4	29.02% <100.00%> (+0.02%)	⬆️
Windows_1	29.04% <ø> (ø)
Windows_2	56.34% <ø> (ø)
Windows_3	37.90% <ø> (ø)
Windows_4	29.02% <100.00%> (+0.02%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sejli]

Nice catch! Thanks for the search strategy unit tests as well.

Changelog workflow failing because it's under the wrong section in the description.

[github-actions]

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.