Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] use roundUp when converting timestamp for PPL #8935

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

joshuali925
Copy link
Member

@joshuali925 joshuali925 commented Nov 26, 2024

Description

When selecting Today, the time range would be now/d to now/d, which currently resolves to the same timestamp. This PR fixes it so that toDate is resolved while rounding up.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: use roundUp when converting timestamp for PPL

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@joshuali925 joshuali925 changed the title [Discover] Fix roundUp when converting timestamp for PPL [Discover] use roundUp when converting timestamp for PPL Nov 26, 2024
Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.88%. Comparing base (073a9ff) to head (53b6d79).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8935   +/-   ##
=======================================
  Coverage   60.87%   60.88%           
=======================================
  Files        3802     3802           
  Lines       91072    91072           
  Branches    14375    14375           
=======================================
+ Hits        55444    55446    +2     
+ Misses      32086    32085    -1     
+ Partials     3542     3541    -1     
Flag Coverage Δ
Linux_1 29.02% <0.00%> (ø)
Linux_2 56.39% <0.00%> (ø)
Linux_3 37.91% <100.00%> (+0.01%) ⬆️
Linux_4 29.00% <0.00%> (ø)
Windows_1 29.03% <0.00%> (ø)
Windows_2 56.34% <0.00%> (ø)
Windows_3 37.91% <100.00%> (+<0.01%) ⬆️
Windows_4 29.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants