Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Keep previous query result if current query result in error" #8923

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

abbyhu2000
Copy link
Member

Description

This reverts commit bca4f5c.

Issues Resolved

Screenshot

Testing the changes

Changelog

  • fix: Revert "Keep previous query result if current query result in error"

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 60.88%. Comparing base (539675e) to head (98ccb60).

Files with missing lines Patch % Lines
...ublic/application/view_components/canvas/index.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8923   +/-   ##
=======================================
  Coverage   60.88%   60.88%           
=======================================
  Files        3802     3802           
  Lines       91070    91068    -2     
  Branches    14374    14373    -1     
=======================================
  Hits        55444    55444           
+ Misses      32085    32083    -2     
  Partials     3541     3541           
Flag Coverage Δ
Linux_1 29.02% <0.00%> (+<0.01%) ⬆️
Linux_2 56.39% <ø> (ø)
Linux_3 37.90% <0.00%> (+<0.01%) ⬆️
Linux_4 29.00% <0.00%> (+<0.01%) ⬆️
Windows_1 29.03% <0.00%> (+<0.01%) ⬆️
Windows_2 56.34% <ø> (ø)
Windows_3 37.90% <0.00%> (-0.01%) ⬇️
Windows_4 29.00% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant