Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide time filter when query assistant is active #8921

Conversation

ruanyl
Copy link
Member

@ruanyl ruanyl commented Nov 25, 2024

Description

Update query assistant UX:

  1. when query assistant is active(assistant input expanded), hide the time filter and do NOT add the time filter to the PPL query
  2. when query assistant is collapse, display the time filter and add the time filter to PPL

Issues Resolved

Screenshot

Screen.Recording.2024-11-25.at.20.19.36.mov

Testing the changes

Changelog

  • feat: hide time filter when query assistant input is expanded

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes missing coverage. Please review.

Project coverage is 60.88%. Comparing base (539675e) to head (34790b3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
.../query_string/language_service/language_service.ts 42.85% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8921   +/-   ##
=======================================
  Coverage   60.88%   60.88%           
=======================================
  Files        3802     3802           
  Lines       91070    91094   +24     
  Branches    14374    14379    +5     
=======================================
+ Hits        55444    55464   +20     
- Misses      32085    32089    +4     
  Partials     3541     3541           
Flag Coverage Δ
Linux_1 29.01% <0.00%> (-0.01%) ⬇️
Linux_2 56.39% <ø> (ø)
Linux_3 37.90% <66.66%> (+<0.01%) ⬆️
Linux_4 29.01% <65.21%> (+0.01%) ⬆️
Windows_1 29.03% <0.00%> (-0.01%) ⬇️
Windows_2 56.34% <ø> (ø)
Windows_3 37.90% <66.66%> (-0.01%) ⬇️
Windows_4 29.01% <65.21%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant