-
Notifications
You must be signed in to change notification settings - Fork 898
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use currently selected data source when no source attached to saved query #8883
Use currently selected data source when no source attached to saved query #8883
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8883 +/- ##
=======================================
Coverage 60.85% 60.86%
=======================================
Files 3802 3802
Lines 91062 91052 -10
Branches 14376 14370 -6
=======================================
Hits 55419 55419
+ Misses 32104 32094 -10
Partials 3539 3539
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
src/plugins/data/public/ui/saved_query_flyouts/open_saved_query_flyout.tsx
Outdated
Show resolved
Hide resolved
…uery Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
7638610
to
ff39b6d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were there not tests for most of these files? What is our plan to address?
Can you share a video/gif of the experience to help validate these changes?
src/plugins/data/public/ui/saved_query_flyouts/open_saved_query_flyout.tsx
Show resolved
Hide resolved
Added video showing:
For the tests, we do have tests for Open flyout but not for Save flyout, will add it to our follow up tasks document |
Signed-off-by: Amardeepsingh Siglani <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
approving assuming it passes ci
…uery (#8883) Opening a saved query that has no dataset stored with it, resets the currently selected dataset in the picker which breaks the query experience since the user will need to reselect the dataset which will then reset the query. * use currently selected data source when no source attached to saved query Signed-off-by: Amardeepsingh Siglani <[email protected]> * Changeset file for PR #8883 created/updated * refactored fix Signed-off-by: Amardeepsingh Siglani <[email protected]> * revert license change Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit a8d383b) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…uery (opensearch-project#8883) Opening a saved query that has no dataset stored with it, resets the currently selected dataset in the picker which breaks the query experience since the user will need to reselect the dataset which will then reset the query. * use currently selected data source when no source attached to saved query Signed-off-by: Amardeepsingh Siglani <[email protected]> * Changeset file for PR opensearch-project#8883 created/updated * refactored fix Signed-off-by: Amardeepsingh Siglani <[email protected]> * revert license change Signed-off-by: Amardeepsingh Siglani <[email protected]> --------- Signed-off-by: Amardeepsingh Siglani <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Opening a saved query that has no dataset stored with it, resets the currently selected dataset in the picker which breaks the query experience since the user will need to reselect the dataset which will then reset the query.
This PR adds a check for this case and retains the currently selected dataset
Testing the changes
Tested using local setup
Screen.Recording.2024-11-18.at.9.02.20.PM.mov
Changelog
Check List
yarn test:jest
yarn test:jest_integration