[Discover] Dataset search on page load issues #8871
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kavilla
requested review from
ananzh,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Required a double click on search and then also potentially loading issue. Issue n/a Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
kavilla
force-pushed
the
kavilla/searchonloaddataset
branch
from
5cb3eb1
to
87f7cc7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8871 +/- ##
=======================================
Coverage 60.93% 60.94%
=======================================
Files 3800 3800
Lines 90880 90878 -2
Branches 14324 14324
=======================================
Hits 55382 55382
+ Misses 31969 31968 -1
+ Partials 3529 3528 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kawika Avilla <[email protected]>
| // A saved search is created on every page load, so we check the ID to see if we're loading a | ||
| // previously saved search or if it is just transient | ||
| return ( | ||
| services.uiSettings.get(SEARCH_ON_PAGE_LOAD_SETTING) || | ||
| datasetPreference || | ||
| uiSettings.get(SEARCH_ON_PAGE_LOAD_SETTING) || |
There was a problem hiding this comment.
why repeat this when part of datasetPreference assignment above?
There was a problem hiding this comment.
i believe i was just over thinking. in terms of code it is redundant but i was little bit worried that return true if undefined isn't the most accurate depiction of what should happen.
but with fresh eyes that doesn't really make sense. in terms of the ci taking an hour, could this be a fast follow?
abbyhu2000
approved these changes
Nov 15, 2024
virajsanghvi
approved these changes
Nov 15, 2024
| // A saved search is created on every page load, so we check the ID to see if we're loading a | ||
| // previously saved search or if it is just transient | ||
| return ( | ||
| services.uiSettings.get(SEARCH_ON_PAGE_LOAD_SETTING) || | ||
| datasetPreference || | ||
| uiSettings.get(SEARCH_ON_PAGE_LOAD_SETTING) || |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Dataset search on page load issues Required a double click on search and then also potentially loading issue. Issue n/a Signed-off-by: Kawika Avilla <[email protected]> * Clean up dependencies Signed-off-by: Kawika Avilla <[email protected]> * Addresses issue Signed-off-by: Kawika Avilla <[email protected]> * add some tests Signed-off-by: Kawika Avilla <[email protected]> * Changeset file for PR #8871 created/updated --------- Signed-off-by: Kawika Avilla <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 42df421) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000
pushed a commit
that referenced
this pull request
Nov 15, 2024
* Dataset search on page load issues Required a double click on search and then also potentially loading issue. Issue n/a * Clean up dependencies * Addresses issue * add some tests * Changeset file for PR #8871 created/updated --------- (cherry picked from commit 42df421) Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Required a double click on search and then also potentially loading issue.
Issues Resolved
n/a
Screenshot
Testing the changes
Unit tests. Also was able to recreate the bug. Switch the index pattern type config to not search on page load then switch off settings. I was able to run into the bug that required me to click twice to actually get results
Changelog
Check List
yarn test:jestyarn test:jest_integration