Fix a typo while inspecting values for large numerals in OSD and the JS client #8839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miki <[email protected]>
Ref: opensearch-project/opensearch-js#889 Signed-off-by: Miki <[email protected]>
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8839 +/- ##
=======================================
Coverage 60.86% 60.87%
=======================================
Files 3799 3799
Lines 90761 90761
Branches 14294 14294
=======================================
+ Hits 55246 55248 +2
+ Misses 32005 32004 -1
+ Partials 3510 3509 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hailong-am
reviewed
Nov 13, 2024
Comment on lines
+87
to
+95
| //ToDo: Remove when opensearch-js is released to include https://github.com/opensearch-project/opensearch-js/pull/889 | ||
| promises.push( | ||
| patchFile('node_modules/@opensearch-project/opensearch/lib/Serializer.js', [ | ||
| { | ||
| from: 'val < Number.MAX_SAFE_INTEGER', | ||
| to: 'val < Number.MIN_SAFE_INTEGER', | ||
| }, | ||
| ]) | ||
| ); |
There was a problem hiding this comment.
2.13.0 been released https://github.com/opensearch-project/opensearch-js/releases/tag/2.13.0, guess we can remove this?
kavilla
reviewed
Nov 15, 2024
| @@ -69,7 +69,7 @@ export const parse = ( | |||
| numeralsAreNumbers && | |||
| typeof val === 'number' && | |||
| isFinite(val) && | |||
| (val < Number.MAX_SAFE_INTEGER || val > Number.MAX_SAFE_INTEGER) | |||
| (val < Number.MIN_SAFE_INTEGER || val > Number.MAX_SAFE_INTEGER) | |||
kavilla
approved these changes
Nov 15, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 15, 2024
…JS client (#8839) * [@osd/std] Fix typo while inspecting values for large numerals Signed-off-by: Miki <[email protected]> * Patch @opensearch-project/opensearch to fix a typo Ref: opensearch-project/opensearch-js#889 Signed-off-by: Miki <[email protected]> * Changeset file for PR #8839 created/updated --------- Signed-off-by: Miki <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit e993d24) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix a typo while inspecting values for large numerals in OSD and the JS client
Note:
Since JS client 2.x has breaking changes, we cannot adopt it immediately and cannot wait for it to be fixed; hence the client is patched with the commit.
Changelog
Check List
yarn test:jestyarn test:jest_integration