Add setting to turn extending numeric precision on or off #8837
Conversation
AMoo-Miki
requested review from
ananzh,
kavilla,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8837 +/- ##
==========================================
+ Coverage 60.85% 60.89% +0.03%
==========================================
Files 3802 3802
Lines 91059 91062 +3
Branches 14376 14376
==========================================
+ Hits 55417 55451 +34
+ Misses 32103 32059 -44
- Partials 3539 3552 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
AMoo-Miki
force-pushed
the
long-numeral-switch
branch
from
79ec26e
to
ce41763
Compare
| @@ -108,4 +108,5 @@ export const UI_SETTINGS = { | |||
| QUERY_DATAFRAME_HYDRATION_STRATEGY: 'query:dataframe:hydrationStrategy', | |||
| SEARCH_QUERY_LANGUAGE_BLOCKLIST: 'search:queryLanguageBlocklist', | |||
| NEW_HOME_PAGE: 'home:useNewHomePage', | |||
| DATA_WITH_LONG_NUMERALS: 'data:withLongNumerals', | |||
There was a problem hiding this comment.
nit: i think i originally did data as well. but then was convinced to use search because then we can group it with the search category. not a strong opinion on this though
There was a problem hiding this comment.
I locked in on data because this is queried by functionality not limited to search.
Signed-off-by: Kawika Avilla <[email protected]>
There was a problem hiding this comment.
sorry my pr caused a conflict on this pr so i just fixed it on github. do you mind verifying miki it's all good?
also one thing i think we should do is move this to the workspace setting or even better yet allow for request options from the query editor would make life a lot easier for developers vs an advanced setting to toggle percision or not
Thanks. Didn't see anything glaring.
Requests can choose to ignore or entertain the precision setting. I do see value for this to ALSO be in the workspace setting since not all users will have workspaces enabled. Will have to see how values are inherited from config and advanced settings to the workspace (later). Thanks for the suggestion. |
| notifications.toasts, | ||
| trackUiMetric, | ||
| history, | ||
| uiSettings, |
There was a problem hiding this comment.
uiSettings is a service, would it ever change?
| value: true, | ||
| description: i18n.translate('data.advancedSettings.data.withLongNumeralsText', { | ||
| defaultMessage: | ||
| "Turn on for precise handling of extremely large numbers. Turn off to optimize performance when high precision for large values isn't required.", |
There was a problem hiding this comment.
should this tell user what the threshold is before losing precision?
Description
Add setting to turn extending numeric precision on or off
Screenshot
Changelog
Check List
yarn test:jestyarn test:jest_integration