Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove data enhancement options from yaml config #8828

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Remove data enhancement options from yaml config #8828

merged 3 commits into from
Nov 8, 2024

Conversation

d-rowe
Copy link
Member

@d-rowe d-rowe commented Nov 7, 2024 •
edited
Loading

Description

Remove data enhancement options from yaml config now it is controlled by Advanced Settings.

Changelog

  • chore: Remove data enhancement options from yaml config now it is controlled by Advanced Settings

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Nov 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.86%. Comparing base (af4943d) to head (2da3a31).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8828      +/-   ##
==========================================
+ Coverage   60.80%   60.86%   +0.06%     
==========================================
  Files        3798     3799       +1     
  Lines       90738    90761      +23     
  Branches    14292    14294       +2     
==========================================
+ Hits        55170    55246      +76     
+ Misses      32065    32005      -60     
- Partials     3503     3510       +7
Flag Coverage Δ
Linux_1 29.04% <ø> (-0.01%) ⬇️
Linux_2 56.39% <ø> (ø)
Linux_3 37.80% <ø> (+0.14%) ⬆️
Linux_4 29.87% <ø> (-0.01%) ⬇️
Windows_1 29.06% <ø> (-0.01%) ⬇️
Windows_2 56.34% <ø> (ø)
Windows_3 37.81% <ø> (+0.15%) ⬆️
Windows_4 29.87% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "chore". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "chore". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 7, 2024

❌ Invalid Prefix For Manual Changeset Creation

Invalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files.

If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description.

kavilla
kavilla approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@kavilla kavilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

sejli
sejli approved these changes Nov 7, 2024
View reviewed changes
Copy link
Member

@sejli sejli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@kavilla kavilla merged commit 696b792 into opensearch-project:main Nov 8, 2024
68 of 69 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Nov 8, 2024
@github-actions @d-rowe @opensearch-changeset-bot
Remove data enhancement options from yaml config (#8828)
b9b6b82 
* Remove deprecated data enhancements config option

Signed-off-by: Daniel Rowe <[email protected]>

* Changeset file for PR #8828 created/updated

---------

Signed-off-by: Daniel Rowe <[email protected]>
Co-authored-by: Daniel Rowe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 696b792)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Nov 8, 2024
Merged
@d-rowe d-rowe deleted the config-clean branch November 8, 2024 19:01
Hailong-am pushed a commit that referenced this pull request Nov 11, 2024
@opensearch-trigger-bot @github-actions
@d-rowe @opensearch-changeset-bot
Remove data enhancement options from yaml config (#8828) (#8836)
94ee553 
* Remove deprecated data enhancements config option



* Changeset file for PR #8828 created/updated

---------




(cherry picked from commit 696b792)

Signed-off-by: Daniel Rowe <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Daniel Rowe <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sejli sejli sejli approved these changes

@kavilla kavilla kavilla approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
backport 2.x discover for discover reinvent discover-next first-time-contributor v2.19.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d-rowe @kavilla @sejli