[discover] temporarily disable recent datasets #8816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With workspaces disabled, recent datasets works fine. However the dataset service does not have the concept of workspaces yet so instead of adding a new feature we are opting for recent datasets not yielding any results. The dataset selector already handles displaying or not if no recent datasets. Follow up issue: opensearch-project#8814 Signed-off-by: Kawika Avilla <[email protected]>
kavilla
requested review from
ananzh,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
github-actions
bot
added
Skip-Changelog
virajsanghvi
approved these changes
Nov 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8816 +/- ##
=======================================
Coverage 60.78% 60.78%
=======================================
Files 3798 3798
Lines 90701 90701
Branches 14284 14284
=======================================
+ Hits 55133 55134 +1
+ Misses 32068 32067 -1
Partials 3500 3500
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashwin-pc
approved these changes
Nov 6, 2024
|
Skipping CI group 10 since the related tests havent been merged in yet from the functional test repo |
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 6, 2024
With workspaces disabled, recent datasets works fine. However the dataset service does not have the concept of workspaces yet so instead of adding a new feature we are opting for recent datasets not yielding any results. The dataset selector already handles displaying or not if no recent datasets. Follow up issue: #8814 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit 4f6b287) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
abbyhu2000
pushed a commit
that referenced
this pull request
Nov 8, 2024
With workspaces disabled, recent datasets works fine. However the dataset service does not have the concept of workspaces yet so instead of adding a new feature we are opting for recent datasets not yielding any results. The dataset selector already handles displaying or not if no recent datasets. Follow up issue: #8814 (cherry picked from commit 4f6b287) Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With workspaces disabled, recent datasets works fine. However the dataset service does not have the concept of workspaces yet so instead of adding a new feature we are opting for recent datasets not yielding any results. The dataset selector already handles displaying or not if no recent datasets.
Follow up issue:
#8814
Issues Resolved
n/a
Screenshot
Testing the changes
locally and jest tests
Changelog
Check List
yarn test:jestyarn test:jest_integration