[Discover] fix error construction and retrieving status #8807
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a follow up fix for #8565, in case
response.data.body
is an Error object, passing it to Error constructor callsString(Error)
which returns[object object]
. Additionally, iferror.message
is a valid JSON, the route will get status code fromJSON.parse(error.message).status
, which is not always present.The PR changes error construction to use
response.data.body.message
if available, and useserror.status
ifstatus
is not available in parsed JSON.Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration