-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace]Fix flights sample data copy in workspace assets page #8786
Merged
SuZhou-Joe
merged 4 commits into
opensearch-project:main
from
wanglam:fix-search-visualization-sample-data-filter-missing-workspace-id
Nov 7, 2024
Merged
[Workspace]Fix flights sample data copy in workspace assets page #8786
SuZhou-Joe
merged 4 commits into
opensearch-project:main
from
wanglam:fix-search-visualization-sample-data-filter-missing-workspace-id
Nov 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lin Wang <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8786 +/- ##
==========================================
- Coverage 60.78% 60.78% -0.01%
==========================================
Files 3798 3798
Lines 90701 90705 +4
Branches 14284 14286 +2
==========================================
Hits 55136 55136
- Misses 32065 32067 +2
- Partials 3500 3502 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wanglam
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
November 1, 2024 10:17
…missing-workspace-id
…missing-workspace-id
ruanyl
approved these changes
Nov 6, 2024
SuZhou-Joe
approved these changes
Nov 6, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 7, 2024
* Fix workspace id missing in sample data filter meta index Signed-off-by: Lin Wang <[email protected]> * Changeset file for PR #8786 created/updated --------- Signed-off-by: Lin Wang <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit af4943d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Hailong-am
pushed a commit
that referenced
this pull request
Nov 8, 2024
…) (#8825) * Fix workspace id missing in sample data filter meta index * Changeset file for PR #8786 created/updated --------- (cherry picked from commit af4943d) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes an issue where the flights sample data failed to copy to other workspaces due to missing index patterns in the workspace assets page. The root cause of this issue was that the index under the import sample data saved object's search source filter metadata was not regenerated with the data source ID and workspace ID. The visualization migration function adds used index patterns from the imported sample data saved object's search source. After that, when we call the duplicate saved objects API to copy assets, it returns a
missing_references
error, and the assets are not copied.To address this issue, we need to add index pattern ID regeneration logic in the import sample data util.
Screenshot
No UI changes
Testing the changes
yarn osd bootstrap --single-version loose
config/opensearch_dashboards.yml
yarn start --no-base-path
Changelog
Check List
yarn test:jest
yarn test:jest_integration