[workspace]Fix/UI of assets table #8519
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opensearch-changeset-bot bot
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 8, 2024
Qxisylolo
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8519 +/- ##
=======================================
Coverage 60.85% 60.86%
=======================================
Files 3802 3802
Lines 91062 91074 +12
Branches 14376 14379 +3
=======================================
+ Hits 55419 55430 +11
- Misses 32104 32105 +1
Partials 3539 3539
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ruanyl
reviewed
Oct 30, 2024
...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
Outdated
Show resolved
Hide resolved
...ins/saved_objects_management/public/management_section/objects_table/saved_objects_table.tsx
Outdated
Show resolved
Hide resolved
opensearch-changeset-bot bot
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 30, 2024
Qxisylolo
force-pushed
the
fix/UI_of_assets_table
branch
from
bdda7c2
to
495fe77
Compare
opensearch-changeset-bot bot
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 31, 2024
Qxisylolo
force-pushed
the
fix/UI_of_assets_table
branch
2 times, most recently
from
c09ae37
to
50de911
Compare
opensearch-changeset-bot bot
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 31, 2024
Qxisylolo
force-pushed
the
fix/UI_of_assets_table
branch
from
1c905bc
to
746db1c
Compare
opensearch-changeset-bot bot
added a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Oct 31, 2024
SuZhou-Joe
reviewed
Nov 12, 2024
| @@ -283,13 +298,71 @@ export class Table extends PureComponent<TableProps, TableState> { | |||
| 'data-test-subj': 'updated-at', | |||
| render: (updatedAt: string) => updatedAt && moment(updatedAt).format(dateFormat), | |||
| } as EuiTableFieldDataColumnType<SavedObjectWithMetadata<any>>, | |||
| ...columnRegistry.getAll().map((column) => { | |||
There was a problem hiding this comment.
We are not supposed to delete the columnRegistry here, it is an extension point for other plugins to register their customized column.
There was a problem hiding this comment.
Thanks for the comment, already updated
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
Qxisylolo
force-pushed
the
fix/UI_of_assets_table
branch
from
223dd7d
to
ef28e15
Compare
SuZhou-Joe
reviewed
Nov 19, 2024
| @@ -224,7 +223,7 @@ export class Table extends PureComponent<TableProps, TableState> { | |||
| <EuiToolTip position="top" content={getSavedObjectLabel(type)}> | |||
| <EuiIcon | |||
| aria-label={getSavedObjectLabel(type)} | |||
| type={object.meta.icon || 'apps'} | |||
| type={object.type === 'config' ? 'gear' : object.meta.icon || 'app'} | |||
There was a problem hiding this comment.
Why don't we just changed the meta.icon?
There was a problem hiding this comment.
Thanks for all the comments, updated.
SuZhou-Joe
reviewed
Nov 19, 2024
| panelPaddingSize="s" | ||
| data-test-subj="workspace-column-popover" | ||
| > | ||
| {workspaceNames?.slice(1).map((ws) => ( |
There was a problem hiding this comment.
The ws may be undefined, shall we filter those workspace out?
SuZhou-Joe
reviewed
Nov 19, 2024
Comment on lines
32
to
34
| expect(getByTestId('workspace-column-popover')).toBeInTheDocument(); | ||
| expect(getByText('foo')).toBeInTheDocument(); | ||
| expect(getByText('bar')).toBeInTheDocument(); |
There was a problem hiding this comment.
Nit: we could use findByText or findByTestId for such kind of assertion, those commands have retry mechanism out of the box.
Signed-off-by: Qxisylolo <[email protected]>
Signed-off-by: Qxisylolo <[email protected]>
SuZhou-Joe
reviewed
Nov 28, 2024
| setShowBadgePopover(false); | ||
| }; | ||
|
|
||
| if (workspaceNames) { |
There was a problem hiding this comment.
Suggested change
| if (workspaceNames) { | |
| if (workspaceNames?.length) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr addresses the UI of assets table by:
Screenshot
Changelog
Check List
yarn test:jestyarn test:jest_integration