Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Backport 2.x][VisBuilder-Next] Migrate legacy visualizations to visbuilder by mapping the url (#7529) #7832

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

SheyGao
Copy link
Contributor

@SheyGao SheyGao commented Aug 23, 2024

Backport of #7529

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 43.85965% with 32 lines in your changes missing coverage. Please review.

Project coverage is 63.92%. Comparing base (458e859) to head (22e6bd1).
Report is 29 commits behind head on 2.x.

Files with missing lines Patch % Lines
...ic/application/utils/construct_vis_builder_path.ts 5.26% 18 Missing ⚠️
...application/utils/use/use_saved_vis_builder_vis.ts 0.00% 6 Missing ⚠️
...s_react/public/table_list_view/table_list_view.tsx 0.00% 2 Missing ⚠️
...ilder/public/application/utils/use/use_can_save.ts 0.00% 2 Missing ⚠️
...ct/public/table_list_view/edit_action_dropdown.tsx 95.83% 0 Missing and 1 partial ⚠️
...pplication/components/data_tab/secondary_panel.tsx 0.00% 1 Missing ⚠️
...is_builder/public/application/utils/breadcrumbs.ts 0.00% 1 Missing ⚠️
...plication/utils/state_management/metadata_slice.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7832      +/-   ##
==========================================
- Coverage   63.92%   63.92%   -0.01%     
==========================================
  Files        3659     3661       +2     
  Lines       81350    81399      +49     
  Branches    12969    12976       +7     
==========================================
+ Hits        52005    52031      +26     
- Misses      26159    26228      +69     
+ Partials     3186     3140      -46     
Flag Coverage Δ
Linux_1 30.18% <7.01%> (-0.02%) ⬇️
Linux_2 55.99% <ø> (ø)
Linux_3 40.46% <7.69%> (-0.02%) ⬇️
Linux_4 31.51% <88.46%> (+0.03%) ⬆️
Windows_1 30.19% <7.01%> (-0.02%) ⬇️
Windows_2 55.94% <ø> (ø)
Windows_3 40.46% <7.69%> (-0.02%) ⬇️
Windows_4 31.51% <88.46%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ing the url (opensearch-project#7529)

* migration of visualization objects to visbuilder
Signed-off-by: Shey Gao <[email protected]>

* update layover

Signed-off-by: Shey Gao <[email protected]>

* fixed a bug

Signed-off-by: Shey Gao <[email protected]>

* Changeset file for PR opensearch-project#7529 created/updated

---------

Signed-off-by: Shey Gao <[email protected]>
Co-authored-by: Shey Gao <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2313372)
@ashwin-pc ashwin-pc merged commit 0e10ba4 into opensearch-project:2.x Aug 30, 2024
62 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants