Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace] Refactor workspace detail page #7598

Merged

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Jul 31, 2024

Description

Refactor workspace detail page

Issues Resolved

#7597

Screenshot

2024-07-31.14.46.44.mp4

Testing the changes

Changelog

  • feat: [Workspace] Refactor workspace detail page

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

Attention: Patch coverage is 91.76471% with 21 lines in your changes missing coverage. Please review.

Project coverage is 63.83%. Comparing base (36af5e7) to head (e5dae0c).
Report is 198 commits behind head on main.

Files with missing lines Patch % Lines
.../workspace_detail/opensearch_connections_table.tsx 90.90% 1 Missing and 3 partials ⚠️
...c/components/workspace_detail/workspace_detail.tsx 92.30% 2 Missing and 2 partials ⚠️
...omponents/workspace_form/workspace_detail_form.tsx 77.77% 4 Missing ⚠️
...ents/workspace_detail/select_data_source_panel.tsx 94.28% 0 Missing and 2 partials ⚠️
...mponents/workspace_detail/workspace_bottom_bar.tsx 75.00% 1 Missing and 1 partial ⚠️
...ic/components/workspace_form/use_workspace_form.ts 81.81% 0 Missing and 2 partials ⚠️
...s/workspace_form/workspace_detail_form_details.tsx 86.66% 2 Missing ⚠️
...onents/workspace_detail/workspace_detail_panel.tsx 93.75% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7598      +/-   ##
==========================================
+ Coverage   63.75%   63.83%   +0.08%     
==========================================
  Files        3639     3643       +4     
  Lines       80461    80644     +183     
  Branches    12800    12822      +22     
==========================================
+ Hits        51297    51481     +184     
+ Misses      26028    26027       -1     
  Partials     3136     3136              
Flag Coverage Δ
Linux_1 30.04% <91.76%> (+0.19%) ⬆️
Linux_2 55.82% <ø> (ø)
Linux_3 40.39% <ø> (ø)
Linux_4 31.30% <ø> (ø)
Windows_1 30.08% <91.76%> (+0.21%) ⬆️
Windows_2 55.77% <ø> (ø)
Windows_3 40.39% <ø> (ø)
Windows_4 31.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl
ruanyl previously approved these changes Aug 15, 2024
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
@ruanyl ruanyl merged commit 2165e03 into opensearch-project:main Aug 15, 2024
67 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7598-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2165e036a23764b055ac21acadb18894145c9e72
# Push it to GitHub
git push --set-upstream origin backport/backport-7598-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-7598-to-2.x.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 16, 2024
* refactor workspace detail page

Signed-off-by: yubonluo <[email protected]>

* Changeset file for PR #7598 created/updated

* add datasource list page

Signed-off-by: yubonluo <[email protected]>

* add workspace detail hash router

Signed-off-by: yubonluo <[email protected]>

* reset useless update

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* add unit tests

Signed-off-by: yubonluo <[email protected]>

* add unit tests

Signed-off-by: yubonluo <[email protected]>

* Fix left navigation overlapped with bottom bar

Signed-off-by: yubonluo <[email protected]>

* update workspace detail use case

Signed-off-by: yubonluo <[email protected]>

* It should only support change to the “ALL” use case

Signed-off-by: yubonluo <[email protected]>

* fix error

Signed-off-by: yubonluo <[email protected]>

* fix errors

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* optimize the code

Signed-off-by: yubonluo <[email protected]>

* fix test error

Signed-off-by: yubonluo <[email protected]>

---------

Signed-off-by: yubonluo <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2165e03)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 19, 2024
* refactor workspace detail page



* Changeset file for PR #7598 created/updated

* add datasource list page



* add workspace detail hash router



* reset useless update



* optimize the code



* add unit tests



* add unit tests



* Fix left navigation overlapped with bottom bar



* update workspace detail use case



* It should only support change to the “ALL” use case



* fix error



* fix errors



* optimize the code



* optimize the code



* fix test error



---------



(cherry picked from commit 2165e03)

Signed-off-by: yubonluo <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants