-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Workspace] Refactor workspace detail page #7598
[Workspace] Refactor workspace detail page #7598
Conversation
Signed-off-by: yubonluo <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7598 +/- ##
==========================================
+ Coverage 63.75% 63.83% +0.08%
==========================================
Files 3639 3643 +4
Lines 80461 80644 +183
Branches 12800 12822 +22
==========================================
+ Hits 51297 51481 +184
+ Misses 26028 26027 -1
Partials 3136 3136
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
src/plugins/workspace/public/components/workspace_form/workspace_detail_form.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_form/workspace_detail_form.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
src/plugins/workspace/public/components/workspace_detail/association_data_source_modal.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_detail/select_data_source_panel.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_detail/workspace_detail_panel.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_form/workspace_detail_form.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/workspace_form/workspace_detail_form_details.tsx
Show resolved
Hide resolved
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
Signed-off-by: yubonluo <[email protected]>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-7598-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 2165e036a23764b055ac21acadb18894145c9e72
# Push it to GitHub
git push --set-upstream origin backport/backport-7598-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x Then, create a pull request where the |
* refactor workspace detail page Signed-off-by: yubonluo <[email protected]> * Changeset file for PR #7598 created/updated * add datasource list page Signed-off-by: yubonluo <[email protected]> * add workspace detail hash router Signed-off-by: yubonluo <[email protected]> * reset useless update Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> * add unit tests Signed-off-by: yubonluo <[email protected]> * add unit tests Signed-off-by: yubonluo <[email protected]> * Fix left navigation overlapped with bottom bar Signed-off-by: yubonluo <[email protected]> * update workspace detail use case Signed-off-by: yubonluo <[email protected]> * It should only support change to the “ALL” use case Signed-off-by: yubonluo <[email protected]> * fix error Signed-off-by: yubonluo <[email protected]> * fix errors Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> * optimize the code Signed-off-by: yubonluo <[email protected]> * fix test error Signed-off-by: yubonluo <[email protected]> --------- Signed-off-by: yubonluo <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 2165e03) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* refactor workspace detail page * Changeset file for PR #7598 created/updated * add datasource list page * add workspace detail hash router * reset useless update * optimize the code * add unit tests * add unit tests * Fix left navigation overlapped with bottom bar * update workspace detail use case * It should only support change to the “ALL” use case * fix error * fix errors * optimize the code * optimize the code * fix test error --------- (cherry picked from commit 2165e03) Signed-off-by: yubonluo <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Refactor workspace detail page
Issues Resolved
#7597
Screenshot
2024-07-31.14.46.44.mp4
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration