Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discover-next] disable show doc links for PPL #7585

Merged
merged 2 commits into from
Jul 30, 2024

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jul 30, 2024

Description

Disabling showing the surrounding doc links for PPL that require specific DSL queries.

Issues Resolved

n/a

Changelog

  • fix: do not show surround doc links for PPL

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Disabling showing the surrounding doc links for PPL that require
specific DSL queries.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.67%. Comparing base (d0618df) to head (59f61e2).
Report is 234 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7585      +/-   ##
==========================================
+ Coverage   63.64%   63.67%   +0.03%     
==========================================
  Files        3630     3630              
  Lines       79545    79545              
  Branches    12609    12609              
==========================================
+ Hits        50628    50654      +26     
+ Misses      25888    25817      -71     
- Partials     3029     3074      +45     
Flag Coverage Δ
Linux_1 30.75% <ø> (ø)
Linux_2 55.58% <ø> (?)
Linux_3 40.37% <ø> (ø)
Linux_4 31.55% <ø> (ø)
Windows_1 30.77% <ø> (ø)
Windows_2 55.53% <ø> (ø)
Windows_3 40.37% <ø> (ø)
Windows_4 31.56% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LDrago27 LDrago27 merged commit 7a9e9ed into opensearch-project:main Jul 30, 2024
67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
* [discover-next] disable show doc links for PPL

Disabling showing the surrounding doc links for PPL that require
specific DSL queries.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>

* Changeset file for PR #7585 created/updated

---------

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7a9e9ed)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
* [discover-next] disable show doc links for PPL

Disabling showing the surrounding doc links for PPL that require
specific DSL queries.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>

* Changeset file for PR #7585 created/updated

---------

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 7a9e9ed)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ananzh pushed a commit that referenced this pull request Jul 30, 2024
* [discover-next] disable show doc links for PPL

Disabling showing the surrounding doc links for PPL that require
specific DSL queries.

Issue:
n/a



* Changeset file for PR #7585 created/updated

---------



(cherry picked from commit 7a9e9ed)

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
* [discover-next] disable show doc links for PPL

Disabling showing the surrounding doc links for PPL that require
specific DSL queries.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>

* Changeset file for PR opensearch-project#7585 created/updated

---------

Signed-off-by: Kawika Avilla <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants