Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable non index pattern datasources redirection when new nav is on and query enhancement is off #7584

Closed

Conversation

mengweieric
Copy link
Collaborator

@mengweieric mengweieric commented Jul 30, 2024

Description

Disable non index pattern datasources redirection when new nav is on and query enhancement is off.

Issues Resolved

N/A

Screenshot

Testing the changes

Changelog

  • fix: Disable non index pattern datasources redirection when new nav is on and query enhancement is off

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Signed-off-by: Eric <[email protected]>
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.25%. Comparing base (9320b9e) to head (6987c39).
Report is 347 commits behind head on 2.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              2.x    #7584      +/-   ##
==========================================
- Coverage   63.83%   54.25%   -9.58%     
==========================================
  Files        3637     3350     -287     
  Lines       80464    76477    -3987     
  Branches    12777    12160     -617     
==========================================
- Hits        51362    41495    -9867     
- Misses      25974    32311    +6337     
+ Partials     3128     2671     -457     
Flag Coverage Δ
Linux_1 29.87% <0.00%> (-0.01%) ⬇️
Linux_2 ?
Linux_3 40.44% <100.00%> (+<0.01%) ⬆️
Linux_4 31.46% <0.00%> (-0.01%) ⬇️
Windows_1 29.89% <0.00%> (-0.01%) ⬇️
Windows_2 ?
Windows_3 40.44% <100.00%> (+<0.01%) ⬆️
Windows_4 31.46% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there conflicts in s3 redirection when new features are enabled? and does it need tests to ensure the behavior?

@mengweieric mengweieric changed the title disable s3 redirection when new nav is on and query enhancement is off Disable non index pattern datasources redirection when new nav is on and query enhancement is off Jul 30, 2024
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

ashwin-pc
ashwin-pc previously approved these changes Jul 30, 2024
joshuali925
joshuali925 previously approved these changes Jul 30, 2024
@mengweieric mengweieric dismissed stale reviews from joshuali925 and ashwin-pc via c319eb3 July 31, 2024 00:18
Signed-off-by: Eric <[email protected]>
Copy link
Contributor

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

@sejli sejli removed the v2.17.0 label Sep 3, 2024
@mengweieric
Copy link
Collaborator Author

Put the notes here: This PR was raised and determined, after spoke to @ashwin-pc , as an Ad hoc, workaround fix at the time for redirection on flint datasource to Log explorer with the conditions: New navigation is on and query enhancement is off. The PR was the fix attempt to be included for 2.16 but was not able to make it. The issue happened due to the new nav changes broke the previously working redirection. Closed this PR as we should still consider fix the redirection rather than filter out non-index patterns datasources as long as flint usage is still a valid use case when that conditions are active. Please reopen it if we still want this as the long term changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants