-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable non index pattern datasources redirection when new nav is on and query enhancement is off #7584
Conversation
Signed-off-by: Eric <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Eric <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #7584 +/- ##
==========================================
- Coverage 63.83% 54.25% -9.58%
==========================================
Files 3637 3350 -287
Lines 80464 76477 -3987
Branches 12777 12160 -617
==========================================
- Hits 51362 41495 -9867
- Misses 25974 32311 +6337
+ Partials 3128 2671 -457
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are there conflicts in s3 redirection when new features are enabled? and does it need tests to ensure the behavior?
src/plugins/data/public/data_sources/datasource_selector/datasource_selectable.tsx
Show resolved
Hide resolved
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Signed-off-by: Eric <[email protected]>
Signed-off-by: Eric <[email protected]>
Signed-off-by: Eric <[email protected]>
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Put the notes here: This PR was raised and determined, after spoke to @ashwin-pc , as an Ad hoc, workaround fix at the time for redirection on flint datasource to Log explorer with the conditions: New navigation is on and query enhancement is off. The PR was the fix attempt to be included for 2.16 but was not able to make it. The issue happened due to the new nav changes broke the previously working redirection. Closed this PR as we should still consider fix the redirection rather than filter out non-index patterns datasources as long as flint usage is still a valid use case when that conditions are active. Please reopen it if we still want this as the long term changes. |
Description
Disable non index pattern datasources redirection when new nav is on and query enhancement is off.
Issues Resolved
N/A
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration