Fix discover options' location #7581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abbyhu2000 <[email protected]>
abbyhu2000
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
Signed-off-by: abbyhu2000 <[email protected]>
kavilla
previously approved these changes
Jul 30, 2024
kavilla
reviewed
Jul 30, 2024
| @@ -95,15 +95,15 @@ export const DiscoverChart = ({ | |||
| ); | |||
|
|
|||
| const toggleLabel = i18n.translate('queryEditor.collapse', { | |||
There was a problem hiding this comment.
can you update this i18n translate
call it something like histogram.collapse
kavilla
reviewed
Jul 30, 2024
| @@ -95,15 +95,15 @@ export const DiscoverChart = ({ | |||
| ); | |||
|
|
|||
| const toggleLabel = i18n.translate('queryEditor.collapse', { | |||
| defaultMessage: 'Toggle query editor', | |||
| defaultMessage: 'Toggle discover histogram', | |||
There was a problem hiding this comment.
I think you can just say Toggle histogram already in discover page would be redudant
Signed-off-by: abbyhu2000 <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7581 +/- ##
=======================================
Coverage 63.67% 63.67%
=======================================
Files 3630 3630
Lines 79545 79545
Branches 12609 12609
=======================================
Hits 50652 50652
Misses 25819 25819
Partials 3074 3074
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ananzh
approved these changes
Jul 30, 2024
kavilla
approved these changes
Jul 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
* fix discover options Signed-off-by: abbyhu2000 <[email protected]> * Changeset file for PR #7581 created/updated * fix discover options Signed-off-by: abbyhu2000 <[email protected]> * update tooltip Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit 3cfcc8a) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
LDrago27
pushed a commit
that referenced
this pull request
Jul 30, 2024
* fix discover options * Changeset file for PR #7581 created/updated * fix discover options * update tooltip --------- (cherry picked from commit 3cfcc8a) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Qxisylolo
pushed a commit
to Qxisylolo/OpenSearch-Dashboards
that referenced
this pull request
Aug 1, 2024
* fix discover options Signed-off-by: abbyhu2000 <[email protected]> * Changeset file for PR opensearch-project#7581 created/updated * fix discover options Signed-off-by: abbyhu2000 <[email protected]> * update tooltip Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix discover options' location when query enhancement is off.
Issues Resolved
Screenshot
When toggle is off:
When toggle is on:
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration