Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix browser warnings #7550

Merged
merged 12 commits into from
Aug 7, 2024
Merged

Conversation

Kapian1234
Copy link
Contributor

@Kapian1234 Kapian1234 commented Jul 29, 2024

Description

Added key props in ‘PageRender’, ‘setupHome’, and ‘HomeListCard’.

Resolved 'intl' object not found error by using i18n.translate.

Resolved the issue of duplicate 'addNavLinksToGroup' calls to prevent the "Navlink of workspace_list has already been registered in group settingsAndSetup".

Modified the expect of addNavLinksToGroup in workspace plugin.test.js

Issues Resolved

closes #7515

Screenshot

Testing the changes

Changelog

  • fix: Resolve some browser warnings

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Jul 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 63.65%. Comparing base (352d2e9) to head (8759e7b).
Report is 1 commits behind head on main.

Files Patch % Lines
...rc/plugins/home/public/application/home_render.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7550      +/-   ##
==========================================
- Coverage   63.65%   63.65%   -0.01%     
==========================================
  Files        3632     3632              
  Lines       80060    80059       -1     
  Branches    12683    12683              
==========================================
- Hits        50965    50962       -3     
- Misses      25990    25991       +1     
- Partials     3105     3106       +1     
Flag Coverage Δ
Linux_1 30.55% <0.00%> (-0.01%) ⬇️
Linux_2 55.58% <ø> (ø)
Linux_3 40.56% <33.33%> (-0.01%) ⬇️
Linux_4 31.30% <33.33%> (ø)
Windows_1 30.56% <0.00%> (-0.01%) ⬇️
Windows_2 55.53% <ø> (ø)
Windows_3 40.56% <33.33%> (ø)
Windows_4 31.30% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ruanyl
ruanyl previously approved these changes Jul 30, 2024
Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Could you maybe remove the duplicate changelogs?

@ruanyl ruanyl added the v2.17.0 label Jul 30, 2024
@Kapian1234
Copy link
Contributor Author

Nice work! Could you maybe remove the duplicate changelogs?

Ok. Thank you!

ruanyl
ruanyl previously approved these changes Aug 2, 2024
@ruanyl ruanyl merged commit ca89488 into opensearch-project:main Aug 7, 2024
67 of 68 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Aug 8, 2024
* fix warnings

Signed-off-by: Kapian1234 <[email protected]>

* fix warnings

Signed-off-by: Kapian1234 <[email protected]>

* Changeset file for PR #7548 created/updated

* fix warnings

Signed-off-by: Kapian1234 <[email protected]>

* Changeset file for PR #7550 created/updated

* Modified the expect of addNavLinksToGroup in workspace plugin.test.js

Signed-off-by: Kapian1234 <[email protected]>

* Modified the expect of addNavLinksToGroup in workspace plugin.test.js

Signed-off-by: Kapian1234 <[email protected]>

* remove the duplicate changelogs

Signed-off-by: Kapian1234 <[email protected]>

* Renamed keys to comply with the directory the file is in

Signed-off-by: Kapian1234 <[email protected]>

---------

Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Jincheng Wan <[email protected]>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit ca89488)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe pushed a commit that referenced this pull request Aug 9, 2024
* fix warnings



* fix warnings



* Changeset file for PR #7548 created/updated

* fix warnings



* Changeset file for PR #7550 created/updated

* Modified the expect of addNavLinksToGroup in workspace plugin.test.js



* Modified the expect of addNavLinksToGroup in workspace plugin.test.js



* remove the duplicate changelogs



* Renamed keys to comply with the directory the file is in



---------





(cherry picked from commit ca89488)

Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Jincheng Wan <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Address Browser Warnings
3 participants