-
Notifications
You must be signed in to change notification settings - Fork 901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix browser warnings #7550
Fix browser warnings #7550
Conversation
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7550 +/- ##
==========================================
- Coverage 63.65% 63.65% -0.01%
==========================================
Files 3632 3632
Lines 80060 80059 -1
Branches 12683 12683
==========================================
- Hits 50965 50962 -3
- Misses 25990 25991 +1
- Partials 3105 3106 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Kapian1234 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! Could you maybe remove the duplicate changelogs?
Signed-off-by: Kapian1234 <[email protected]>
Ok. Thank you! |
src/plugins/workspace/public/components/home_get_start_card/use_case_footer.tsx
Outdated
Show resolved
Hide resolved
src/plugins/workspace/public/components/home_get_start_card/use_case_footer.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Kapian1234 <[email protected]>
Signed-off-by: Jincheng Wan <[email protected]>
* fix warnings Signed-off-by: Kapian1234 <[email protected]> * fix warnings Signed-off-by: Kapian1234 <[email protected]> * Changeset file for PR #7548 created/updated * fix warnings Signed-off-by: Kapian1234 <[email protected]> * Changeset file for PR #7550 created/updated * Modified the expect of addNavLinksToGroup in workspace plugin.test.js Signed-off-by: Kapian1234 <[email protected]> * Modified the expect of addNavLinksToGroup in workspace plugin.test.js Signed-off-by: Kapian1234 <[email protected]> * remove the duplicate changelogs Signed-off-by: Kapian1234 <[email protected]> * Renamed keys to comply with the directory the file is in Signed-off-by: Kapian1234 <[email protected]> --------- Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: Jincheng Wan <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit ca89488) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* fix warnings * fix warnings * Changeset file for PR #7548 created/updated * fix warnings * Changeset file for PR #7550 created/updated * Modified the expect of addNavLinksToGroup in workspace plugin.test.js * Modified the expect of addNavLinksToGroup in workspace plugin.test.js * remove the duplicate changelogs * Renamed keys to comply with the directory the file is in --------- (cherry picked from commit ca89488) Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: Kapian1234 <[email protected]> Signed-off-by: Jincheng Wan <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Description
Added
key
props in ‘PageRender’, ‘setupHome’, and ‘HomeListCard’.Resolved 'intl' object not found error by using i18n.translate.
Resolved the issue of duplicate 'addNavLinksToGroup' calls to prevent the "Navlink of workspace_list has already been registered in group settingsAndSetup".
Modified the expect of addNavLinksToGroup in workspace plugin.test.js
Issues Resolved
closes #7515
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration