[Look&Feel] Use small context menu across the board #7486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi and
sejli
as code owners
zhongnansu
added
backport 2.x
enhancement
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7486 +/- ##
==========================================
- Coverage 63.67% 63.67% -0.01%
==========================================
Files 3630 3630
Lines 79545 79545
Branches 12609 12609
==========================================
- Hits 50652 50650 -2
- Misses 25819 25820 +1
- Partials 3074 3075 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
github-actions
bot
added
Skip-Changelog
src/plugins/home/public/application/components/sample_data_view_data_button.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Zhongnan Su <[email protected]>
zhongnansu
force-pushed
the
lnf-small-context-menu
branch
from
fb52b3a
to
cfa0838
Compare
virajsanghvi
approved these changes
Jul 30, 2024
zhyuanqi
approved these changes
Jul 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 31, 2024
Signed-off-by: Zhongnan Su <[email protected]> (cherry picked from commit 61d5c49) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhongnansu
pushed a commit
that referenced
this pull request
Aug 5, 2024
(cherry picked from commit 61d5c49) Signed-off-by: Zhongnan Su <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Found 2 places that we need to use small context Menu. Along with #7057 , Now we have applied small context menu across the whole OSD codebase
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration