Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing the PR I noticed that there were still a couple things that we should change, here are my suggestions. The main issues and changes I tried to address are:
Main change
where(selected_events.consultation_id.is_not_in(pf_ids))
Smaller changes include:
measures.define_defaults()
selected_events
,selected_medications
) for the measures interval at the top of the script_pfid_
) or Pharmacy First consultation date (_pfdate_
)