Add ethnicity breakdown and codelist #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I have also limited denominator to just male and female |
milanwiedemann
approved these changes
Oct 3, 2024
There was a problem hiding this comment.
This looks good to me, I suggest we just add the ethnicity desctiption and make some formatting changes, see #21 for my suggestions. I'm not sure why we get zeros in the numerators and think we should run the code to see what we get out, this might be related to the dummy data.
…reakdown Update report breakdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When looking at the numerators in pf_codes_conditions_measures.csv, they are all 0 - this is only happening after I implemented ethnicity. Any ideas why?