Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rudimentary scheduled check of dev container #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add rudimentary scheduled check of dev container #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd55286
Add rudimentary dev container test
StevenMaude Aug 14, 2024
1a88e5d
Check workflow action versions with Dependabot
StevenMaude Aug 14, 2024
cefb43b
Uncomment the Slack notification step in test CI
StevenMaude Sep 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/dependabot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
version: 2

updates:
- package-ecosystem: "github-actions"
directory: "/"
schedule:
interval: "monthly"
28 changes: 28 additions & 0 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
name: Test dev container

on:
schedule:
- cron: "56 5 * * *"
workflow_dispatch:

jobs:
dev-container:
runs-on: ubuntu-latest
steps:
- name: Checkout repository
uses: actions/checkout@v4

- name: Test dev container
uses: devcontainers/ci@a56d055efecd725e8cfe370543b6071b79989cc8 # v0.3.1900000349
with:
runCmd: opensafely run run_all

- name: Notify Slack on failure
if: failure() && github.event_name == 'schedule'
uses: zuplo/github-action-slack-notify-build@cf8e7e66a21d76a8125ea9648979c30920195552 # v2
env:
SLACK_BOT_TOKEN: ${{ secrets.SLACK_BOT_TOKEN }}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thought: This repository will need to get access to this secret, if this PR is merged.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but I think an 🦩 should be able to grant access to the org secret for this right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, that's right.

This was just a reminder if someone merges this PR and doesn't realise it.

with:
channel_id: C069YDR4NCA
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: This is the #team-rap channel.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If they own this, then that seems right. Although if #team-rap own this repo then why are we adding scheduled tests to it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I asked the RAP team in Slack if they thought this PR useful or not. We can leave it up to them to decide.

If it's not thought to be useful, it's fine by me to close it without merging, of course.

status: "Scheduled dev container test run failure"
color: danger