Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise ValidationError for empty or incomplete action configs #345

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Raise ValidationError for empty or incomplete action configs #345

merged 1 commit into from
Oct 9, 2024

Conversation

alarthast
Copy link
Contributor

Part of #344. Necessary due to the noactions.yaml fixture in opensafely-cli that tests for this.

  • Validates that actions in project.yaml contain both run and output keys, i.e. the necessary arguments for Actions.build to be called.
  • Further validations can be handled within Actions.build().

@alarthast alarthast force-pushed the validate-action-input-config branch from d111e76 to 5134323 Compare October 8, 2024 17:03
@alarthast alarthast mentioned this pull request Oct 8, 2024
Closed
5 tasks
@alarthast alarthast force-pushed the validate-action-input-config branch from 9f9a7cd to 5134323 Compare October 9, 2024 11:50
@alarthast alarthast merged commit add1b8e into main Oct 9, 2024
30 checks passed
@alarthast alarthast deleted the validate-action-input-config branch October 9, 2024 11:52
@evansd evansd mentioned this pull request Oct 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebkwok rebkwok rebkwok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alarthast @rebkwok