Use JoinColumn annotation for relationship mappings

[evie-lau]

What's changed?

OpenJPA -> EclipseLink migration recipe
When a @Column annotated attribute has a relationship mapping (@OneToOne or @ManyToOne), replace with @JoinColumn and drop certain annotation attributes.

What's your motivation?

https://wiki.eclipse.org/EclipseLink/Examples/JPA/Migration/OpenJPA/Mappings#.40Column_in_Relationship_Mappings

Anything in particular you'd like reviewers to focus on?

Checklist

• I've added unit tests to cover both positive and negative cases
• I've read and applied the recipe conventions and best practices
• I've used the IntelliJ IDEA auto-formatter on affected files

[evie-lau]

I noticed the doAfterVisit is applying changes to the whole file instead of the filtered VariableDeclaration.
Is there a way to apply those other recipes specifically to the current item? Or would I have to build my own JavaTemplate for it?
Modified recipe to only change the affected VariableDeclaration.

[timtebeek]

Near perfect; Great to see you reuse as much as possible. We'll wait for @cjobinabo to return before a merge.

[cjobinabo]

The following these cases should be ported over from our bucket:

• @OnetoOne used with @column (with a few attributes provided)
• @manytoone and @column, both without any attributes
• @OneToOnee and @column, both without any attributes

We should also test the use of these annotations within a sub class here as well.

[evie-lau]

Did you mean subclass extending the @Entity class? or an inner class inside the @Entity class?

[cjobinabo]

Looks good