-
Notifications
You must be signed in to change notification settings - Fork 78
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Recipe to call ToolProvider methods as static methods, not on instanc…
…es (#477) * adding recipe RemovedToolProvider * updated tests * Implement RemovedToolProviderConstructor as declarative recipe --------- Co-authored-by: anuram <[email protected]> Co-authored-by: Tim te Beek <[email protected]>
- Loading branch information
3 people
authored
May 21, 2024
1 parent
64f8669
commit 047c19f
Showing
2 changed files
with
91 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
75 changes: 75 additions & 0 deletions
75
src/test/java/org/openrewrite/java/migrate/RemovedToolProviderConstructorTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,75 @@ | ||
| /* | ||
| * Copyright 2024 the original author or authors. | ||
| * <p> | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * <p> | ||
| * https://www.apache.org/licenses/LICENSE-2.0 | ||
| * <p> | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.openrewrite.java.migrate; | ||
|
|
||
| import org.junit.jupiter.api.Test; | ||
| import org.openrewrite.DocumentExample; | ||
| import org.openrewrite.test.RecipeSpec; | ||
| import org.openrewrite.test.RewriteTest; | ||
|
|
||
| import static org.openrewrite.java.Assertions.java; | ||
|
|
||
| class RemovedToolProviderConstructorTest implements RewriteTest { | ||
|
|
||
| @Override | ||
| public void defaults(RecipeSpec spec) { | ||
| spec.recipeFromResource("/META-INF/rewrite/java-version-17.yml", "org.openrewrite.java.migrate.RemovedToolProviderConstructor"); | ||
| } | ||
|
|
||
| @DocumentExample | ||
| @Test | ||
| void moveToStaticTest() { | ||
| rewriteRun( | ||
| //language=java | ||
| java( | ||
| """ | ||
| import javax.tools.ToolProvider; | ||
| import javax.tools.JavaCompiler; | ||
| import javax.tools.DocumentationTool; | ||
| import java.lang.ClassLoader; | ||
| class RemovedToolProviderConstructorApp { | ||
| void test() throws Exception { | ||
| ToolProvider tp = null; | ||
| JavaCompiler compiler = tp.getSystemJavaCompiler(); | ||
| DocumentationTool dT = tp.getSystemDocumentationTool(); | ||
| ClassLoader cl = tp.getSystemToolClassLoader(); | ||
| System.out.println(ToolProvider.getSystemJavaCompiler()); | ||
| tp.getSystemJavaCompiler().getSourceVersions(); | ||
| } | ||
| } | ||
| """, | ||
| """ | ||
| import javax.tools.ToolProvider; | ||
| import javax.tools.JavaCompiler; | ||
| import javax.tools.DocumentationTool; | ||
| import java.lang.ClassLoader; | ||
| class RemovedToolProviderConstructorApp { | ||
| void test() throws Exception { | ||
| ToolProvider tp = null; | ||
| JavaCompiler compiler = ToolProvider.getSystemJavaCompiler(); | ||
| DocumentationTool dT = ToolProvider.getSystemDocumentationTool(); | ||
| ClassLoader cl = ToolProvider.getSystemToolClassLoader(); | ||
| System.out.println(ToolProvider.getSystemJavaCompiler()); | ||
| ToolProvider.getSystemJavaCompiler().getSourceVersions(); | ||
| } | ||
| } | ||
| """ | ||
| ) | ||
| ); | ||
| } | ||
| } |