Find relocated dependencies #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timtebeek
changed the title
jonathanlermitage/oga-maven-plugin
shanman190
reviewed
Jan 20, 2024
src/main/java/org/openrewrite/java/dependencies/RelocatedDependencyCheck.java
Outdated
Show resolved
Hide resolved
shanman190
approved these changes
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
What's your motivation?
Fixes #58
Anything in particular you'd like reviewers to focus on?
https://github.com/jonathanlermitage/oga-maven-plugin is MIT licensed; we attribute them in the recipe description.
Have you considered any alternatives or workarounds?
We could search and index of Maven central ourselves, similar to
https://github.com/jonathanlermitage/oga-maven-plugin/tree/master/maven-index-search-suspect-coordinates
But that seems an excessive amount of work.
We could at runtime look for relocation hits against Maven Central (or company Maven repositories). Seemed not as reliable or quick neither to implement nor run as recipe, nor is artifact relocation wide spread enough to pick up a substantial amount of relocations.