Add unlessUsing property to RemoveDependency recipe
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jevanlingen
changed the title
unlessUsing propertyunlessUsing property to RemoveDependency
jevanlingen
changed the title
unlessUsing property to RemoveDependencyunlessUsing property to RemoveDependency
jevanlingen
changed the title
unlessUsing property to RemoveDependencyunlessUsing property to RemoveDependency recipe
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/main/java/org/openrewrite/java/dependencies/RemoveDependency.java
Outdated
Show resolved
Hide resolved
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
timtebeek
approved these changes
Nov 13, 2024
timtebeek
deleted the
11-add-a-unlessusing-option-to-the-removedependency-recipe
branch
sambsnyd
pushed a commit
that referenced
this pull request
Dec 11, 2024
* Start implementing `unlessUsing` property * Change test to use a Java source file too; add TODOs * Apply suggestions from code review Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Implement `unlessUsing` property * Nullable options should not be required in Yaml * Adopt UsesType instead of looking for method patterns, to match AddDependency * Reduce warnings --------- Co-authored-by: Tim te Beek <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
Add an
unlessUsingproperty to the RemoveDependency recipe.What's your motivation?
Sometimes you want to remove a dependency, unless it is used by the code.
unlessUsingoption to theRemoveDependencyrecipe #11Have you considered any alternatives or workarounds?
A workaround is just to run current recipe and after migration see if the code still compiles.
Checklist