Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match C# artifactId and version in DependencyInsight #120

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

timtebeek
Copy link
Contributor

@timtebeek timtebeek commented Aug 27, 2024

Should help fill out DevCenter for C#: https://app.moderne.io/devcenter/C%23

@timtebeek timtebeek added the enhancement New feature or request label Aug 27, 2024
@timtebeek timtebeek requested a review from sjungling August 27, 2024 17:01
@timtebeek timtebeek self-assigned this Aug 27, 2024
example = "Microsoft*",
required = false)
@Nullable
String artifactIdPattern;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In .NET / NuGet land people talk about packages rather than artifacts, so we may want to rename things and also adjust display names and descriptions accordingly, as to not confuse the user.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you even go as far as from DependencyInsight to PackageInsight ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure. I think dependency might still be a generic enough term. While the C# project files use the term package references, I think developers probably also refer to them as dependencies. But I am guessing a bit here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then let's stick with just the renamed field for now then, to keep symmetry with the Maven/Gradle and Nodejs recipes and visualizations we already have. We can gather feedback around this from the first users.

@timtebeek timtebeek merged commit 3076667 into main Aug 27, 2024
2 checks passed
@timtebeek timtebeek deleted the match-csharp-artifactId-and-version branch August 27, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants