Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crameri-Michelson colour maps #21

Merged
merged 2 commits into from
Oct 12, 2023
Merged

Conversation

DanielMichelson
Copy link

One colour map for depolarization ratio and another for RHOHV.

@zssherman
Copy link
Collaborator

Thanks @DanielMichelson for the PR! @mgrover1 I'm going to work on the PR and get it ready with the init etc

@zssherman
Copy link
Collaborator

zssherman commented Oct 10, 2023

@DanielMichelson @mgrover1 With trying to shorten the naming, would MCRoma and MCOleron work?(MichelsonCrameri, this way instead of CM to not be confused with ColorMap) Or do we prefer CrameriMichelsonOleron and CrameriMichelsonRoma? Or does anyone have other suggestions?

@DanielMichelson
Copy link
Author

DanielMichelson commented Oct 10, 2023

Whatever works best for the project. The use of each colour map is specific to a given variable (moment), DR and RHOHV; neither colour map is very useful with other variables, so that's why they are each mentioned in the current file names. But the other colour maps that are in the project are more general, and can be applied to more than a single variable. Maybe you would prefer to leave the variable name out of the colour map's name.

@mgrover1
Copy link
Collaborator

Whatever works best for the project. The use of each colour map is specific to a given variable (moment), DR and RHOHV; neither colour map is very useful with other variables, so that's why they are each mentioned in the current file names. But the other colour maps that are in the project are more general, and can be applied to more than a single variable. Maybe you would prefer to leave the variable name out of the colour map's name.

I think sticking with the original proposal here... using
CM_depol
CM_rhohv

This strikes a good balance between being short enough to easily type out, while also being descriptive for colormaps for those moments. Any thoughts here @DanielMichelson ?

@zssherman zssherman merged commit 8ce63b1 into openradar:main Oct 12, 2023
@zssherman
Copy link
Collaborator

@DanielMichelson Going to merge this in and work on the changes in another PR, thanks again for submitting this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants