-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: Module reporting XML schema errors #972
Open
carlwilson
wants to merge
12
commits into
dev/1.33
Choose a base branch
from
fix/report-schema-issues
base: dev/1.33
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DEV: JHOVE v1.33.0-SNAPSHOT
Fixed minor issues in the XmlHandler, JPEG2000 and HTML modules that meant reporting output was not valid against the schema. - replaced the `XmlHandler:cleanURIString()` implementation with something less radical that doesn't produce invalid XML in testing; - fixed badly formatted dates in the HTML module document details; - fixed bug in the JPEG2000 module where empty `CompositeLayerHeader` lists were created, these fail report schema validation; - bumped the JPEG2000 and HTML module versions and release dates; - added fixes to test scripts for the above; and - removed some commented out code from XML reporting module.
- simplified loop handling of the show routines.
Error messages now include a link to the OPF Wiki page that explains the error in more detail. - wiki links generated in XML, JSON and text reporting modules and GUI viewer; - added JHOVE XML report schemas to `jhove-core` resources; and - added a `Handlers` class to `edu.harvard.hul.ois.jhove.handler` for link generation and imminent refactoring.
- bumped handler versions; and - patched test scripts for new output.
- bumped POM versions.
- fixed versioning conflicts.
Merge 1.32.0 SNAPSHOT to integration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed minor issues in the XmlHandler, JPEG2000 and HTML modules that meant reporting output was not valid against the schema.
XmlHandler:cleanURIString()
implementation with something less radical that doesn't produce invalid XML in testing;CompositeLayerHeader
lists were created, these fail report schema validation;