Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Module reporting XML schema errors #972

Open
wants to merge 12 commits into
base: dev/1.33
Choose a base branch
from

Conversation

carlwilson
Copy link
Member

Fixed minor issues in the XmlHandler, JPEG2000 and HTML modules that meant reporting output was not valid against the schema.

  • replaced the XmlHandler:cleanURIString() implementation with something less radical that doesn't produce invalid XML in testing;
  • fixed badly formatted dates in the HTML module document details;
  • fixed bug in the JPEG2000 module where empty CompositeLayerHeader lists were created, these fail report schema validation;
  • bumped the JPEG2000 and HTML module versions and release dates;
  • added fixes to test scripts for the above; and
  • removed some commented out code from XML reporting module.

Fixed minor issues in the XmlHandler, JPEG2000 and HTML modules that meant reporting output was not valid against the schema.

- replaced the `XmlHandler:cleanURIString()` implementation with something less radical that doesn't produce invalid XML in testing;
- fixed badly formatted dates in the HTML module document details;
- fixed bug in the JPEG2000 module where empty `CompositeLayerHeader` lists were created, these fail report schema validation;
- bumped the JPEG2000 and HTML module versions and release dates;
- added fixes to test scripts for the above; and
- removed some commented out code from XML reporting module.
- simplified loop handling of the show routines.
Error messages now include a link to the OPF Wiki page that explains the error in more detail.

- wiki links generated in XML, JSON and text reporting modules and GUI viewer;
- added JHOVE XML report schemas to `jhove-core` resources; and
- added a `Handlers` class to `edu.harvard.hul.ois.jhove.handler` for link generation and imminent refactoring.
@carlwilson carlwilson self-assigned this Nov 13, 2024
@carlwilson carlwilson added the bug A product defect that needs fixing label Nov 13, 2024
@carlwilson carlwilson changed the base branch from integration to dev/1.33 January 22, 2025 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A product defect that needs fixing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant