Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Sander Roet <[email protected]>
  • Loading branch information
dwhswenson and sroet authored Nov 1, 2021
1 parent def35eb commit d1f430a
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion paths_cli/compiling/_gendocs/config_handler.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def load_config(config_file):
name of YAML or JSON file
"""
loader = select_loader(config_file)
with open(config_file, mode='r') as f:
with open(config_file, mode='r', encoding='utf-8') as f:
dct = loader(f)

result = {category: DocCategoryInfo(**details)
Expand Down
1 change: 0 additions & 1 deletion paths_cli/compiling/_gendocs/docs_generator.py
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,6 @@ def generate_category_rst(self, category_plugin):
str :
RST string for this category
"""
# TODO: move type_required to DocCategoryInfo (default True)
cat_info = self._get_cat_info(category_plugin)
type_required = cat_info.type_required
rst = f".. _compiling--{category_plugin.label}:\n\n"
Expand Down

0 comments on commit d1f430a

Please sign in to comment.