Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RESTWS-957: Fix Swagger errors displayed on the openmrs swagger api docs page #76

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

mherman22
Copy link
Member

@mherman22 mherman22 commented Oct 1, 2024

@mherman22 mherman22 requested a review from ibacher October 4, 2024 11:52
pom.xml Outdated
Comment on lines 333 to 334
<!-- Pour contourner un bug à la génération par Spring-boot 2.4.x :
Failed to execute goal org.apache.maven.plugins:maven-resources-plugin:3.2.0:resources (default-resources) on project application-etude: Input length = 1 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C'est en français pourquoi? Et aussi, pourquoi la référence à Spring Boot?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pâte stackoverflow, permettez-moi de mettre à jour cela. 😄

Comment on lines +312 to +320
<dependencies>
<!-- Needed because of maven 3.9.0 backward compatibility issue,
See : https://github.com/revelc/impsort-maven-plugin/issues/64 -->
<dependency>
<groupId>org.codehaus.plexus</groupId>
<artifactId>plexus-utils</artifactId>
<version>3.5.1</version>
</dependency>
</dependencies>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes here are also changes we should make to the archetype for modules.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noted!, will make a commit to the sdk for it

@mherman22 mherman22 requested a review from ibacher October 6, 2024 18:56
@ibacher ibacher merged commit f63baa1 into openmrs:main Oct 7, 2024
1 check passed
@mherman22 mherman22 deleted the REST-WS-957 branch October 20, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants