(test) O3-4176: E2E test for invalid biometrics #2094
+50
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdaud
changed the title
|
Size Change: 0 B Total Size: 15.9 MB ℹ️ View Unchanged
|
kdaud
force-pushed
the
O3-4070
branch
2 times, most recently
from
21b0b32
to
7017c4d
Compare
kdaud
changed the title
ibacher
reviewed
Nov 10, 2024
e2e/specs/biometrics.spec.ts
Outdated
| @@ -66,6 +66,52 @@ test('Record biometrics', async ({ page }) => { | |||
| }); | |||
| }); | |||
|
|
|||
| test('Record abnormal biometrics', async ({ page }) => { | |||
There was a problem hiding this comment.
These are not "abnormal" these are "invalid". Abnormal, in the context of vitals has a specific, clinically relevant meaning and it's best not to mess that up.
Also, weights over 250kg should not be invalid to enter. The heaviest person still living used to weight 610kg. Vitals like height, weight, BMI and MUAC—where there is no reason that a measurement has a "natural" cap—should not have absolute maximums. This differs from values like O2 Sat, which has a natural maximum (it's a percentage).
There was a problem hiding this comment.
Yes, it makes sense to add values for Temperature, BP, heart rate, respiration rate, and SpO2 if we need to check for invalid values, since they have specific limits.
kdaud
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Screenshots
Related Issue
https://issues.openmrs.org/browse/O3-4176
Other