(fix) Properly sanitize and initialize cloned fields #429
+37
−24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR fixes an issue where cloned fields skip logic doesn't work as expected within obs group instances. The issue has been fixed by including all form fields (including the freshly cloned fields) in the expression runner's context.
Screenshots
Issue:
Screen.Recording.2024-10-31.at.12.55.40.mov
Fixed:
Related Issue
https://openmrs.atlassian.net/browse/O3-4157
Other