Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Properly sanitize and initialize cloned fields #429

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

samuelmale
Copy link
Member

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes a conventional commit label. See existing PR titles for inspiration.
  • My work conforms to the OpenMRS 3.0 Styleguide and design documentation.
  • My work includes tests or is validated by existing tests.

Summary

This PR fixes an issue where cloned fields skip logic doesn't work as expected within obs group instances. The issue has been fixed by including all form fields (including the freshly cloned fields) in the expression runner's context.

Screenshots

Issue:

Screen.Recording.2024-10-31.at.12.55.40.mov

Fixed:

2024-11-25 14-59-43 2024-11-25 15_00_54

Related Issue

https://openmrs.atlassian.net/browse/O3-4157

Other

Copy link

Size Change: +164 B (+0.01%)

Total Size: 1.25 MB

ℹ️ View Unchanged
Filename Size Change
dist/151.js 379 kB 0 B
dist/225.js 2.57 kB 0 B
dist/254.js 88.7 kB 0 B
dist/277.js 1.85 kB 0 B
dist/300.js 642 B 0 B
dist/335.js 968 B 0 B
dist/353.js 3.02 kB 0 B
dist/41.js 3.37 kB 0 B
dist/539.js 262 kB +115 B (+0.04%)
dist/540.js 2.63 kB 0 B
dist/55.js 758 B 0 B
dist/585.js 112 kB 0 B
dist/635.js 14.4 kB 0 B
dist/690.js 11.5 kB 0 B
dist/70.js 483 B 0 B
dist/979.js 6.87 kB 0 B
dist/99.js 691 B 0 B
dist/993.js 3.09 kB 0 B
dist/main.js 354 kB +49 B (+0.01%)
dist/openmrs-esm-form-engine-lib.js 3.8 kB 0 B

compressed-size-action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant