(feat) Introduce Location Datasource #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ibacher
reviewed
Aug 22, 2023
samuelmale
reviewed
Aug 22, 2023
src/components/inputs/ui-select-extended/ui-select-extended.tsx
Outdated
Show resolved
Hide resolved
src/components/inputs/ui-select-extended/ui-select-extended.tsx
Outdated
Show resolved
Hide resolved
src/components/inputs/ui-select-extended/ui-select-extended.tsx
Outdated
Show resolved
Hide resolved
kajambiya
changed the title
kajambiya
force-pushed
the
ConceptLocation
branch
from
6789951
to
7bc1b5a
Compare
samuelmale
reviewed
Sep 14, 2023
samuelmale
reviewed
Sep 14, 2023
| import { DataSource } from '../api/types'; | ||
|
|
||
| export class LocationDataSource implements DataSource<OpenmrsResource> { | ||
| private initialUrl: string; |
samuelmale
reviewed
Sep 14, 2023
samuelmale
reviewed
Sep 14, 2023
samuelmale
reviewed
Sep 14, 2023
src/datasources/data-source.ts
Outdated
|
|
||
| toUuidAndDisplay(data: OpenmrsResource): OpenmrsResource { | ||
| if (typeof data.uuid === 'undefined' || typeof data.display === 'undefined') { | ||
| throw new Error(); |
There was a problem hiding this comment.
Can you provide an error message? Something like:
throw new Error("'uuid' or 'display' not found in the OpenMRS object.");
samuelmale
reviewed
Sep 14, 2023
| } | ||
|
|
||
| fetchData(searchTerm: string, config?: Record<string, any>): Promise<any[]> { | ||
| this.url = this.initialUrl; |
There was a problem hiding this comment.
Are there cases where you envision the URL changing for this Datasource? Why parameterize it? Why not fuse it within assuming this Datasource will only be used for locations? Ideally, it should accept adhoc query params through configurations and the search term but I'm not sure I understand why we require a URL in the constructor.
The parameter only makes sense for data sources whose URL might change like the base data source.
samuelmale
changed the title
kajambiya
force-pushed
the
ConceptLocation
branch
from
7bc1b5a
to
e4aacb0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
This PR introduces the location data source. It allows locations to be captured as obs with the help of the ui-select-extended control.
The PR also includes some code refactor to the data-source component.
Screenshots
Screen.Recording.2023-08-22.at.09.17.25.mov
Related Issue
Other