-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-3946: Add support for markdown questions #355
Open
Twiineenock
wants to merge
23
commits into
openmrs:main
Choose a base branch
from
Twiineenock:feat/support-for-markdown-qns
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
5a50c2b
feat: Add support from markdown questions
Twiineenock 7185afd
Merge branch 'main' into feat/support-for-markdown-qns
Twiineenock a329aec
minor fixes
Twiineenock 9dc9747
Merge branch 'feat/support-for-markdown-qns' of github.com:Twiineenoc…
Twiineenock d555079
remove rehype-raw and remark-gfm and minor tweaks
Twiineenock 8325371
(test): Add mock for markdown component
NethmiRodrigo 0928980
(chore): Update form engine and framework
NethmiRodrigo 7e0923f
remove label check from questionMOdal save button
Twiineenock 526cb1f
remove required attributes from label
Twiineenock c932a2e
Merge yarn.lock from main into feat/support-for-markdown-qns
Twiineenock 5953379
Merge branch 'main' into feat/support-for-markdown-qns
Twiineenock 6a4552b
add yarn.lock
Twiineenock 4afe95e
Update yarn.lock
NethmiRodrigo 6e35125
question type is optional
Twiineenock 01a5a9a
question attribute value should have type any
Twiineenock a34c7fb
no-explicit-any for question attribute value
Twiineenock be8822a
control set as default type
Twiineenock 9596868
question type should be required
Twiineenock deb634c
update yarn.lock
Twiineenock f751243
update yarn.lock
Twiineenock af8d7b4
update branch
Twiineenock 8591f6b
Merge branch 'main' into feat/support-for-markdown-qns
Twiineenock 265dda8
MarkdownWrapper should be in its own file
Twiineenock File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
**/dist/* | ||
**/node_modules/* | ||
**/*.d.tsx | ||
__mocks__/* | ||
__mocks__/* |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import React from 'react'; | ||
|
||
export default function ({ children }) { | ||
return <>{children}</>; | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love this type of mocking. It means that the tests cannot actually test this component. Is there a reason we need to stub it out like this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very bad response from me to say this as the reason, but I did this following what we had done in form-engine, because jest threw an error.