-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat) O3-3947: Add toggle type questions to interactive builder #350
Conversation
const [toggleLabelTrue, setToggleLabelTrue] = useState(''); | ||
const [toggleLabelFalse, setToggleLabelFalse] = useState(''); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should initialize these values to show the existing labels since this is in the edit modal.
We would have to update the interfaces in types.ts
to add toggleOptions
to questionOptions
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated this together with the issues you had requested in the closed PR.You can look at it
Hey @Kinotijoan, I see that the PR #349 has the same changes. Can we have the changes in one of the two PRs since its the same ticket and close the other one? |
Hey@NethmiRodrigo ,sure I'll work on it |
Thanks @Kinotijoan! Could you please make the changes that were requested in the closed PR in this one? |
No problem |
…ptions - Updated the toggle label placeholders in the edit-question.modal - Added toggle rendering options to the interactive builder - Modified the translations in en.json to include labelFalse, labelPlaceholder, and labelTrue - Added "Off" and "On" translations in en.json
…ls in edit-question.modal
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Kinotijoan! A minor fix with the translation strings and we should be good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @Kinotijoan!
Requirements
Summary
Enables users to create
toggle
type questions using the interactive builderScreenshots
Related Issue
https://openmrs.atlassian.net/browse/O3-3947
Other
None.