-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(fix) O3-3713: Should not go into infinite loading when conceptId is undefined #336
Conversation
@ibacher @denniskigen @samuelmale I had to update core and framework to get this running but when I do, I get the error about the date picker, so I didn't push yarn.lock |
Size Change: +4 B (0%) Total Size: 3.7 MB ℹ️ View Unchanged
|
You need to add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @NethmiRodrigo! LGTM, save for an issue about the isEmpty
check.
913aca8
to
af46083
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Requirements
Summary
This PR fixes the issue of the backing concept field in the
editQuestionModal
going in to an infinite load if there is no concept or if the concept is set to an empty string.Screenshots
Before the fix:
Screen.Recording.2024-08-08.at.6.28.54.PM.mov
After the fix:
Screen.Recording.2024-08-08.at.6.37.53.PM.mov
Screen.Recording.2024-08-08.at.6.38.29.PM.mov
Related Issue
https://issues.openmrs.org/browse/O3-3713
Other