(fix) O3-3415 : Update scroll height in form-renderer and interactive-builder #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
senthil-athiban
changed the title
…ilder into fix/interactive-builder-height
@senthil-athiban could we have both the interactive builder and the JSON schema editor take up the same height? The interactive builder seems to be a little shorter.
|
|
Sorry about the late review! |
|
Closing this PR since it has being inactive for a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Fixing the height of the form-renderer and interactive builder, and including a scrollbar if contents overflow. This will be useful when the user makes changes using an interactive builder, as the changes can be seen in the schema editor simultaneously.
Screenshots
Before:
https://www.loom.com/share/cd32179bb6c54e8fb368427dd4e1a3c7?sid=949250bb-7eaa-4e27-b0d1-abfbfc8219a2
After:
https://www.loom.com/share/2d421a86876941e59f91b9d30979ac34?sid=3d3ea380-326c-4d72-a574-dc92906afff8
Related Issue
https://openmrs.atlassian.net/browse/O3-3415