(refactor) Replace usages of /ws/rest/v1/ with restBaseUrl
#225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denniskigen
requested changes
Feb 27, 2024
src/hooks/useForm.ts
Outdated
| import type { Form } from '../types'; | ||
|
|
||
| export const useForm = (uuid: string) => { | ||
| const url = `/ws/rest/v1/form/${uuid}?v=full`; | ||
| const url = `${restBaseUrl}/${uuid}?v=full`; |
There was a problem hiding this comment.
Suggested change
| const url = `${restBaseUrl}/${uuid}?v=full`; | |
| const url = `${restBaseUrl}/form/${uuid}?v=full`; |
|
Please add a conventional commit label to your PR title. |
jwnasambu
changed the title
denniskigen
changed the title
/ws/rest/v1/ with restBaseUrl
denniskigen
approved these changes
Mar 1, 2024
|
Thanks, @jwnasambu! |
denniskigen
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Summary
Change all instances of the hard-coded API base URL '/ws/rest/v1/' to use the restBaseUrl variable instead. To enhances maintainability and flexibility of the API base URL configuration.
Screenshots
Not available
Related Issue
https://openmrs.atlassian.net/browse/O3-2815
Other