Skip to content

Commit

Permalink
question type should be required
Browse files Browse the repository at this point in the history
  • Loading branch information
Twiineenock committed Nov 1, 2024
1 parent be8822a commit 9596868
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 1 addition & 0 deletions .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
"rules": {
"react-hooks/exhaustive-deps": "warn",
"react-hooks/rules-of-hooks": "error",
"@typescript-eslint/no-explicit-any": "off",
// not hugely concerned about accidental implicit type coercions for now https://typescript-eslint.io/rules/no-base-to-string
"@typescript-eslint/no-base-to-string": "off",
// The following rules need `noImplicitAny` to be set to `true` in our tsconfig. They are too restrictive for now, but should be reconsidered in future
Expand Down
6 changes: 2 additions & 4 deletions src/types.ts
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,8 @@ export interface Schema {
questions: Array<{
id: string;
label?: string;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
value?: any;
type?: string;
type: string;
required?: string | boolean | RequiredFieldProps;
questionOptions: {
type?: string;
Expand Down Expand Up @@ -118,9 +117,8 @@ export interface Section {
export interface Question {
id: string;
label?: string;
// eslint-disable-next-line @typescript-eslint/no-explicit-any
value?: any;
type?: string;
type: string;
questionOptions: QuestionOptions;
datePickerFormat?: DatePickerType;
questions?: Array<Question>;
Expand Down

0 comments on commit 9596868

Please sign in to comment.