Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRUNK-5801: EncounterType Domain - Switching from Hibernate Mappings to Annotations #4829

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 31 additions & 3 deletions api/src/main/java/org/openmrs/EncounterType.java
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,50 @@
*/
package org.openmrs;

import org.hibernate.annotations.GenericGenerator;
import org.hibernate.annotations.Parameter;
import org.hibernate.envers.Audited;

import javax.persistence.AttributeOverride;
import javax.persistence.Column;
import javax.persistence.Entity;
import javax.persistence.GeneratedValue;
import javax.persistence.GenerationType;
import javax.persistence.Id;
import javax.persistence.JoinColumn;
import javax.persistence.ManyToOne;
import javax.persistence.Table;

/**
* An EncounterType defines how a certain kind of {@link Encounter}.
*
* @see Encounter
*/
@Entity
@Table(name = "encounter_type")
@AttributeOverride(name = "name", column = @Column(name = "name", length = 50, nullable = false, unique = true))
@AttributeOverride(name = "description", column = @Column(name = "description", length = 1024))
@Audited
public class EncounterType extends BaseChangeableOpenmrsMetadata {

public static final long serialVersionUID = 789L;


@Id
@GeneratedValue(strategy = GenerationType.SEQUENCE, generator = "encounter_type_id_seq")
@GenericGenerator(
name = "encounter_type_id_seq",
strategy = "native",
parameters = @Parameter(name = "sequence", value = "encounter_type_encounter_type_id_seq")
)
@Column(name = "encounter_type_id")
private Integer encounterTypeId;


@ManyToOne
@JoinColumn(name = "view_privilege")
private Privilege viewPrivilege;


@ManyToOne
@JoinColumn(name = "edit_privilege")
private Privilege editPrivilege;

// Constructors
Expand Down
1 change: 0 additions & 1 deletion api/src/main/resources/hibernate.cfg.xml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@
<mapping resource="org/openmrs/api/db/hibernate/CareSetting.hbm.xml" />
<mapping resource="org/openmrs/api/db/hibernate/LocationTag.hbm.xml" />
<mapping resource="org/openmrs/api/db/hibernate/LocationAttribute.hbm.xml" />
<mapping resource="org/openmrs/api/db/hibernate/EncounterType.hbm.xml" />
<mapping resource="org/openmrs/api/db/hibernate/EncounterProvider.hbm.xml" />
<mapping resource="org/openmrs/api/db/hibernate/EncounterRole.hbm.xml" />
<mapping resource="org/openmrs/api/db/hibernate/Program.hbm.xml" />
Expand Down

This file was deleted.

2 changes: 2 additions & 0 deletions api/src/test/java/org/openmrs/api/OrderServiceTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,7 @@
import org.openmrs.DrugIngredient;
import org.openmrs.DrugOrder;
import org.openmrs.Encounter;
import org.openmrs.EncounterType;
import org.openmrs.FreeTextDosingInstructions;
import org.openmrs.GlobalProperty;
import org.openmrs.Location;
Expand Down Expand Up @@ -2740,6 +2741,7 @@ public void saveOrder_shouldFailIfTheJavaTypeOfThePreviousOrderDoesNotMatch() th
.addAnnotatedClass(ProgramAttributeType.class)
.addAnnotatedClass(HL7InError.class)
.addAnnotatedClass(OrderType.class)
.addAnnotatedClass(EncounterType.class)
.getMetadataBuilder().build();


Expand Down
Loading